Coder Social home page Coder Social logo

Comments (1)

matthewbub avatar matthewbub commented on June 2, 2024

This was tricky for alot of reasons. We had the usual troubles with working with Mono repos, this required updated the root package.json to utilize the workspaces property. So we now "officially" are using workspaces.

Another issue I encountered was needing to use a specific node version instead of the default version, pnpm requires atleast v16

More fun, the workspaces/tests directory won't place nice with the Github Action environment because it's installing calendar-widgets via relative pathing. To resolve this we had to install around that directory.

- name: Install dependencies
        run: pnpm install --recursive --filter '.../!tests'

The next step was to run the following scripts in the workspaces/calendar-workspaces directory: pnpm run build and pnpm run lint. What's interesting is when I went to test the ESLint action, it was running successfully and passing the build... when it shouldn't be 🙄 I had intentionally set some errors that were failing on my local but they weren't catching in the build. This was the action:

# ...

- name: Install dependencies
        run: pnpm install --recursive --filter '.../!tests'

# ...

- name: Lint calendar-widgets
        working-directory: ./workspaces/calendar-widgets
        run: pnpx eslint --debug './src/**/*.{ts,tsx}' -c .eslintrc.cjs

Turns out, ESLint needed to be installed independently in the dependencies 🤷

- name: Install dependencies
     run: |
          pnpm install --recursive --filter '.../!tests'
          cd workspaces/calendar-widgets
          pnpm install --save-dev eslint

from calendar-widgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.