Comments (1)
This was tricky for alot of reasons. We had the usual troubles with working with Mono repos, this required updated the root package.json
to utilize the workspaces
property. So we now "officially" are using workspaces.
Another issue I encountered was needing to use a specific node version instead of the default version, pnpm requires atleast v16
More fun, the workspaces/tests
directory won't place nice with the Github Action environment because it's installing calendar-widgets
via relative pathing. To resolve this we had to install around that directory.
- name: Install dependencies
run: pnpm install --recursive --filter '.../!tests'
The next step was to run the following scripts in the workspaces/calendar-workspaces
directory: pnpm run build
and pnpm run lint
. What's interesting is when I went to test the ESLint action, it was running successfully and passing the build... when it shouldn't be 🙄 I had intentionally set some errors that were failing on my local but they weren't catching in the build. This was the action:
# ...
- name: Install dependencies
run: pnpm install --recursive --filter '.../!tests'
# ...
- name: Lint calendar-widgets
working-directory: ./workspaces/calendar-widgets
run: pnpx eslint --debug './src/**/*.{ts,tsx}' -c .eslintrc.cjs
Turns out, ESLint needed to be installed independently in the dependencies 🤷
- name: Install dependencies
run: |
pnpm install --recursive --filter '.../!tests'
cd workspaces/calendar-widgets
pnpm install --save-dev eslint
from calendar-widgets.
Related Issues (20)
- Rename `dayComponent` to `customDay`
- Rename `dayNameComponent` to `customDayName`
- Add `examples/with-create-react-app`
- document that user's will need to import the base styles if they want to see the basic ui
- Spread unknown Calendar props into Calendar
- Add onChange event handler to Calendar HOT 1
- Add `name` prop to Calendar component
- research: why cant i see JSDocs in production?
- Replace relative path with actual package in `examples/with-create-react-app`
- bug: Failed to parse sourcemap
- Type error `Could not find a declaration file for module 'calendar-widgets'.`
- Library should be compatible with next.js HOT 1
- Style website footer / mobile responsive view
- Remove magic numbers from eslint rules
- Draft a Month Selector Component
- Draft a Year Selector Component
- User's can't add / create new issues HOT 1
- Refactor the Calendar component
- Upgrade Docusaurus
- Update license to current year HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calendar-widgets.