Bug: formatDate test is failing about calendar-widgets

[matthewbub]

Very interesting to see from another locale! I was unaware it would fail in this manor. We have #70 created which should ultimately resolve this, the getDefaultLocale option will be used to create a more predictable development experience and will be required everywhere locales might apply.

function getDefaultLocale(overrideLocale, fallbackLocale) {
  let userLocale = navigator.language;
  
  if (overrideLocale) {
    userLocale = overrideLocale;
  } else if (!userLocale && fallbackLocale) {
    userLocale = fallbackLocale;
  }
  
  return userLocale;
}

I tried slapping it in everywhere carelessly and everything broke lol. I'll bump this up on the list of priorities and get it ironed out ASAP.

[Ngoakor12]

Just saw the jsdoc documentation of the function that it does indeed default to the user's locale. I thought there was a project default, this one seems flaky because the expected string will always be different depending the user. Unless a helper can be created to get a person's locale and make that the expected string?

[matthewbub]

@Ngoakor12 i've removed the failing test suite for now, to allow folks in other locales to properly test. This temp fix will allow me to iron out a better solution in #70 🙂

please let me know if this solves the failing tests in your local env.

[Ngoakor12]

@Ngoakor12 i've removed the failing test suite for now, to allow folks in other locales to properly test. This temp fix will allow me to iron out a better solution in #70 slightly_smiling_face

please let me know if this solves the failing tests in your local env.

Had a quick look, all the tests are passing :)

Side note: the week was hectic, I will hopefully be able to work on that issue assigned to me and open more

[matthewbub]

No worries at all 💯 thank you for taking the time to run these tests again. It's greatly appreciated!