GetDiagnostics‘s issue about microocpp

[matth-x]

Sorry, need to row back on this. The onRequest listener is executed after the internal MicroOcpp handlers, and in this case only after refreshFilename() gets called.

If I get more feedback about the start- and stopTime in the diagnostics filename, I will add these fields to the refreshFilename() signature as well. For now, the only valid solution is to "rebuild" the GetDiagnostics operation by copying GetDiagnostics.h and GetDiagnostics.cpp into your own sources, changing conflicting names and then overloading the internal GetDiagnostics similar to this:

MicroOcpp/src/MicroOcpp/Model/Diagnostics/DiagnosticsService.cpp

Lines 27 to 28 in 47cc0e4

	context.getOperationRegistry().registerOperation("GetDiagnostics", [this] () {
	return new Ocpp16::GetDiagnostics(*this);});

The overload needs to happen after the initialization of DiagnosticsService.

[matth-x]

Hi @shengxiang200788,

Thanks a lot for the report!

1. Fixed it on main.
2. The default constructor initializes it to 1970-01-01 which means "undefined". The callee should check the timestamp values first:

if (startTime >= MIN_TIME) {
    //startTime defined, process it here
}

3. Nice idea, will think about it. As a workaround for now, you can get the original payload of the GetDiagnostics by setting an "onRequest" listener which is executed with the original OCPP message payload:

MicroOcpp/src/MicroOcpp/Core/OperationRegistry.h

Line 35 in 47cc0e4

void setOnRequest(const char *operationType, OnReceiveReqListener onRequest);

Then you could store the startTime and stopTime strings somewhere and read them again when refreshFilename() is called. Setting the onRequest listener won't interfere the normal execution in the DiagnosticsService.