Comments (3)
While you made a great effort in this project, I can't go ahead and review your code.
Invalid Kanban Review Request
- I understand that you are waiting for your partner to respond, but the right thing to do if your partner is not responding is to reach out to student success. Student success will try to reach out to your partner and give feedback on the collaboration status of your partner.
Note: If you are to continue without your partner, resubmit this link with the feedback from student success that says you should continue without your partner. 👍 🙏
Your Kanban Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
from catalog-of-my-things.
I am submitting again, now with the 3rd group member added
from catalog-of-my-things.
Hi @jfoyarzo , @MattGomb & @Dadadon ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Descriptive issue ✔️
- Setup correctly the Kanban board ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from catalog-of-my-things.
Related Issues (20)
- [1pt] Options in the menu (tm2)
- [0.5pt] Add unit tests for MusicAlbum and genre methods (tm2)
- [3pt] Create MusicAlbum class (tm2)
- [1pt] Create a main.rb (group)
- [1pt] Create items.rb (group)
- [1.5pt] Create Book Class (tm1)
- [1.5pt] Create Label class (tm1)
- [1pt] Add option to main.rb (tm1)
- [1pt] Data preservation (tm1)
- [1pt] Unit tests (tm1)
- [1pt] Create database tables (tm1)
- [1pt] Data preservation (tm2)
- [1pt] Create database schema (tm2)
- [1pt] Unit tests (tm3)
- [1.5pt] Create Game class (tm3)
- [1pt] Data preservation (tm3)
- [1pt] Database tables (tm3)
- [1.5] Create Author class (tm3)
- [1pt] Add options to main.rb file (tm3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from catalog-of-my-things.