Coder Social home page Coder Social logo

Comments (7)

vcastellm avatar vcastellm commented on August 26, 2024

+1

from ansible-consul.

RockingRolli avatar RockingRolli commented on August 26, 2024

+1

from ansible-consul.

trumant avatar trumant commented on August 26, 2024

#70 removes the nginx role dependency altogether but as noted, before making any changes to the install-ui functionality we should really get a TestKitchen test suite together for it.

from ansible-consul.

palmerabollo avatar palmerabollo commented on August 26, 2024

+1

#70 needs to change meta/main.yml to add a condition to the dependencies (when consul_enable_nginx_config == true)

dependencies:
  - { role: franklinkim.nginx, when: consul_is_ui == true and consul_enable_nginx_config and ansible_os_family == "Debian"}
  - { role: geerlingguy.nginx, when: consul_is_ui == true and consul_enable_nginx_config and ansible_os_family == "RedHat"}

from ansible-consul.

trumant avatar trumant commented on August 26, 2024

FYI, there is now a TestKitchen test suite around the UI

from ansible-consul.

mattfinlayson avatar mattfinlayson commented on August 26, 2024

👍

from ansible-consul.

spinx avatar spinx commented on August 26, 2024

Did a PR for this: #90

from ansible-consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.