Coder Social home page Coder Social logo

Some issues about mooring HOT 8 CLOSED

creynders avatar creynders commented on June 10, 2024
Some issues

from mooring.

Comments (8)

creynders avatar creynders commented on June 10, 2024

I feel a bit awkward asking this, but since grappling-hook is a keystone product not mine, I think I have to: could you follow the MIT license rules of attribution, since there are parts literally taken from grappling-hook?

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

@crynders sure thing! I was on the fence as the methods were relatively heavenly modded. So I ended up just calling out the source and giving credit in the readme. Any particular parts you would like credit for?

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

Also great catches on those 2 issues, I'll take a look at them today! 😊

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

@creynders Credit added and copyright edited. Sorry this was just something I whipped up so I even forgot the copyright... my bad.

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

@creynders fixed the data mutability bug, working on the 1 argument being a method bug now

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

@creynders using the exact code you provided for "you can't pass functions as an argument to the function created with" I could not reproduce the issue.

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

The issue (per a side convo with @creynders) is:

hooks.before('cook', false, function(food, next) {
    console.log('cook pre', food); //outputs undefined
    next();
});

var cook = hooks.createHook('cook', function(food) {
    console.log('createHook callback', food);
    return food;
});

cook(function(){});

from mooring.

mattapperson avatar mattapperson commented on June 10, 2024

All issues fixed in 1.0.4

from mooring.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.