Async creation function requires the usage of `new this()` not `new ClassName()` about js-async-init

[tegefaulkes]

Here is the example that demonstrates the problem.

import { CreateDestroyStartStop, ready } from '@matrixai/async-init/dist/CreateDestroyStartStop';

interface X extends CreateDestroyStartStop {}
@CreateDestroyStartStop()
class X {
  static async createXWorks() {
    return new this();
  }
  static async createXFails() {
    return new X();
  }
  async start() {}
  async stop() {}
  async destroy() {}
  
  @ready()
  async thing() {}
}


async function mainWorks () {
  const x = await X.createXWorks();
  await x.start()
  await x.thing();
  await x.stop();
  await x.destroy();
}

async function mainFails () {
  const x = await X.createXFails();
  await x.start()
  await x.thing();
  await x.stop();
  await x.destroy();
}

// void mainWorks();
void mainFails();

mainFails fails with the following error.

[nix-shell:~/matixWorkspace/gitRepos/js-db]$ npm run ts-node -- test.ts

> @matrixai/[email protected] ts-node
> ts-node "test.ts"

TypeError: Cannot read properties of undefined (reading 'isLocked')
    at X.thing (/home/faulkes/matixWorkspace/gitRepos/js-db/node_modules/@matrixai/async-init/src/CreateDestroyStartStop.ts:189:30)
    at mainFails (/home/faulkes/matixWorkspace/gitRepos/js-db/test.ts:44:11)

The decorators here are setting up some state in the constructor. Relevant to this problem it's creating mutex lock and storing it in a property using a symbol as the key.

const initLock = Symbol('initLock');

// Decorator is adding this to the class.
  readonly [initLock]: RWLockWriter;

// The @ready decorator is trying to access it.
this[initLock].isLocked('write')

[tegefaulkes]

Created upstream issue at swc-project/swc#7426

[tegefaulkes]

The upstream wants a playground example showing the problem. I'm going to create one and update the issue.

[CMCDragonkai]

Note that this is not a bug of this library. Users should just make sure to use new this() in their creation functions.

However in this project, we can change all of our tests and examples to use new this().

[CMCDragonkai]

I've updated all the examples and tests to use new this() in 76bc9e3.

I think we can close this for now, as upstream will track that bug. We just have to be aware of this.

@amydevs make sure you know about this.