Coder Social home page Coder Social logo

Comments (6)

dvirberlo avatar dvirberlo commented on July 27, 2024

Addtionally, at src\assets\i18n\he.json:
MusicListTracks singular in hebrew is: "רצועה"
MusicListTracks + MusicListTracksPlural should be "רצועות"

what i am saying is that the plural end form in Hebrew replcaes the last letter of the singular form.
what sould i do?

from litefy.

mathkruger avatar mathkruger commented on July 27, 2024

I think we can change the way that string is formed, creating a new string in the translation file with the plural as a whole. I never worked with RTL language, so, I'm not familiar with the techniques to make it work properly. But, you're free to do it in your own way!

from litefy.

dvirberlo avatar dvirberlo commented on July 27, 2024

Hi.
(recommend to number your comments, best for everyone)

  1. I agree.
  2. In general, you can so must of the work by putting dir="trl" at the (or at the body style direction:rtl).
    but, there are places you will want to keep LTR (for example. the buttons div of previous, play/stop and next).
  3. I very familiar with HTML and Node.js but I never worked with Angular or TypeScript. so if you want me to work on it, it might take time. but it would be a solution to any right aligned language.
  4. If you are intersted in more translations, I recommend to make a translations.md file to explain what files should be translated and basic language style(take opensource.guide as example).

from litefy.

dvirberlo avatar dvirberlo commented on July 27, 2024

Hi, @mathkruger.
As requested, the new plural system PR #26 done.
now, remains just to dive into the Angular i18n-dir...

from litefy.

dvirberlo avatar dvirberlo commented on July 27, 2024

Hi @mathkruger .

  1. I finished the assignment (#31).
  2. I used CSS inset-inline-X which is not compatible with all browsers ( MDN compatibility chart ).
    if you want me to use a way which is more compatible- just let me know!

from litefy.

dvirberlo avatar dvirberlo commented on July 27, 2024

Close the issue?

from litefy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.