Comments (4)
Well, that's one way to clear up whether it's an invariant! 💀
Thank you, @ggevay, for attending to this when I'm OoO!
from materialize.
I'll look at this now.
from materialize.
Btw. I'm somehow getting a slightly different panic:
thread 'tokio:work-56' panicked at src/transform/src/join_implementation.rs:849:36:
attempt to subtract with overflow
stack backtrace:
0: rust_begin_unwind
at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5
1: core::panicking::panic_fmt
at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14
2: core::panicking::panic
at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:127:5
3: mz_transform::join_implementation::differential::plan
at ./src/transform/src/join_implementation.rs:849:36
4: mz_transform::join_implementation::JoinImplementation::action
at ./src/transform/src/join_implementation.rs:458:76
5: mz_transform::join_implementation::JoinImplementation::action_recursive::{{closure}}
at ./src/transform/src/join_implementation.rs:120:17
6: mz_ore::stack::CheckedRecursion::checked_recur::{{closure}}
at ./src/ore/src/stack.rs:191:33
7: stacker::maybe_grow
at /home/gabor/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stacker-0.1.15/src/l
This is for the expression inputs.len() - 2
, so the root cause is probably the same.
from materialize.
I used to think that a 1-input join probably can't occur by the time we reach JoinImplementation
, but I was never sure, and I never dared to put in a soft_assert for this. But #23318 sneaked in a soft_assert, so now we know that this can actually occur :)
Opened a PR to fix it: #24513
from materialize.
Related Issues (20)
- Remove automatic `mz_introspection` cluster name translation
- bazel: Use more minimal and up-to-date C toolchain
- load-generator-key-value.td is flaky due to "preparing query failed: connection closed" HOT 1
- Negative aggregate length for persist sink correction HOT 3
- controller-frontiers.td fails in "Full testdrive in cloudtests" HOT 2
- CPU leak in `TxnsCacheState::data_listen_next` HOT 1
- Delta join index usage reports full scan for all arrangements on the first input
- Add a `soft_assert` that a query's result type is not changed during optimization HOT 1
- release: v0.101.1 required reviews HOT 2
- storage: upsert rehydration can panic when the since is too advanced
- compute: cardinality computations in the new analysis.rs can panic HOT 1
- `EXPLAIN` should specially treat newlines in string literals
- COPY TO S3: Include mz logical timestamp in exported data HOT 3
- copy-to-s3 auth error message is pretty cryptic
- release: v0.102.0 required reviews HOT 3
- miri test "proptest_packed_mz_acl_item_sorts" is flaky due to timeouts
- Unprovisioned or unhealthy clusters can arbitrarily delay compaction of their inputs
- bazel: Auto generating `BUILD.bazel` files from `Cargo.toml`
- bazel: Replace remaining CI build jobs that use Cargo
- release: v0.102.1 required reviews HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialize.