Coder Social home page Coder Social logo

Comments (12)

diegobarle-dev avatar diegobarle-dev commented on May 20, 2024 1

Update: After analysing my codebase I realised that some of the styles defined in my project were somehow overriding the ones defined by the material library (still not sure how that was possible if they were not being referenced upon build). After getting rid of the styles defined in my project the MaterialDatePicker UI seems to be displaying correctly on com.google.android.material:material:1.11.0

from material-components-android.

hunterstich avatar hunterstich commented on May 20, 2024

Hi @mywalkb. Thanks for filing an issue.

For some reason I'm unable to see the images you've uploaded. Do you mind re-attaching the screenshots of the issue?

from material-components-android.

mywalkb avatar mywalkb commented on May 20, 2024

Hi @hunterstich, thank you for your fast reply and sorry for my bad images and slow fix.
I uploaded to external host, because the images have just become so private that not even I can see them anymore, while I was preparing the issue something else happened to me but I thought it was my fault and how I had pasted the link, but no, it seems they are only valid in session.
However I saw that github has uploaded them to its servers.
When in doubt, also post direct links, to avoid them getting lost again

After update to 1.11.0
https://i.ibb.co/SrgqMDH/after1.png
https://i.ibb.co/7QJQsCZ/after2.png

Before update to 1.11.0 with version 1.10.0
https://i.ibb.co/Bt446Hv/before1.png
https://i.ibb.co/KVvqX5s/before2.png

from material-components-android.

diegobarle-dev avatar diegobarle-dev commented on May 20, 2024

The issue also happening with MaterialDatePicker.Builder.datePicker() but I'm unable to fix it with styles.
Screenshot 2024-04-03 at 10 16 48

Adding the following partially fixes the problem but there are still gaps

    <style name="ThemeOverlay.App.MaterialCalendar" parent="@style/ThemeOverlay.MaterialComponents.MaterialCalendar">
        <item name="materialCalendarHeaderSelection">@style/HeaderSelection1</item>
    </style>
    <style name="HeaderSelection1" parent="Widget.MaterialComponents.MaterialCalendar.HeaderSelection">
        <item name="android:background">@color/error_red</item>
    </style>
    val datePicker = MaterialDatePicker.Builder.datePicker()
            .setTitleText(R.string.date_picker_select_date)
            .setSelection(dateValidator.initialDate)
            .setCalendarConstraints(constraintsBuilder.build())
            .setTheme(R.style.ThemeOverlay_App_MaterialCalendar)
            .build()

Screenshot 2024-04-03 at 10 25 33

from material-components-android.

mywalkb avatar mywalkb commented on May 20, 2024

I'm glad to know I'm not the only one with the issue.
I hope @hunterstich can give us a suggestion.

from material-components-android.

hunterstich avatar hunterstich commented on May 20, 2024

@mywalkb do you have dynamic colors enabled? Do you mind attaching a sample that reproduces the issue?

from material-components-android.

mywalkb avatar mywalkb commented on May 20, 2024

@hunterstich yes I have dynamic colors enabled.
I don't have an example to reproduces the issue, but it's an opensource project mywalkb/LSPosed_mod.
Is not only an app, but a more complex project.
The source of app is here mywalkb/LSPosed_mod/tree/main/app/src/main.
In this action zip you can find manager.apk which has the issue with version 1.11.0, while in this action zip you can find manage.apk which has no issue with version 1.10.0, because I choose to revert the update.

from material-components-android.

hunterstich avatar hunterstich commented on May 20, 2024

@mywalkb Are the two different screenshots running on a device with different wallpapers?

from material-components-android.

mywalkb avatar mywalkb commented on May 20, 2024

@hunterstich no, is the same AVD without changes. I installed, run, screenshot, no changes.

from material-components-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.