1.27.2: build fails about mate-panel

[raveit65]

Can you try mate-desktop from master?
Or rebuild my SRPM (1.27.3 + master commits)
https://www.dropbox.com/scl/fi/jzy3cnabi10dxunps8yxw/mate-desktop-1.27.3-2.fc38.src.rpm?rlkey=wk9rvmpjk2ganvitliqa9ypq7&dl=0

[kloczek]

Tested tjat and it sdoes not work. Part of my spec file

URL:            https://mate-desktop.org/
VCS:            https://github.com/mate-desktop/mate-panel/
Source:         https://pub.mate-desktop.org/releases/%(v=%{version}; echo ${v%.*})/%{name}-%{version}.tar.xz
Source:         %{name}_fedora-28.layout
Source:         %{name}_rhel.layout
Patch:          %{VCS}/commit/cf544b71.patch#/%{name}-Hidpi-x11-center-panel-force-quit-popup-window.patch
Patch:          %{VCS}/commit/170842ce.patch#/%{name}-Force-quit-x11-Fix-misalignment-of-popup-with-multim.patch
Patch:          %{VCS}/commit/4c6fc7e3.patch#/%{name}-Wayland-Make-panel-shutdown-button-work-under-waylan.patch
Patch:          %{VCS}/commit/a6ea51bb.patch#/%{name}-Wayland-Fix-force-quit-unsupported-message-dialog.patch
Patch:          %{VCS}/commit/675f72ff.patch#/%{name}-Main-menus-fix-missing-Places-System-icons.patch
Patch:          %{VCS}/commit/353c71ea.patch#/%{name}-status-notifier-fix-a-typo.patch
Patch:          %{VCS}/commit/95a92215.patch#/%{name}-status-notifier-fix-typo.patch
Patch:          %{VCS}/commit/d87c912c.patch#/%{name}-status-notifier-Show-AttentionIcon-when-Status-is-Ne.patch

and ..

[tkloczko@pers-jacek mate-panel]$ grep -r MATE_TYPE_IMAGE_MENU_ITEM /usr/include/
/usr/include/mate-desktop-2.0/libmate-desktop/mate-image-menu-item.h:#define MATE_TYPE_IMAGE_MENU_ITEM            (mate_image_menu_item_get_type ())

So I've added patch:

--- a/mate-panel/panel-menu-items.c
+++ b/mate-panel/panel-menu-items.c
@@ -47,6 +47,7 @@
 #include <libpanel-util/panel-keyfile.h>
 #include <libpanel-util/panel-launch.h>
 #include <libpanel-util/panel-show.h>
+#include <libmate-desktop/mate-image-menu-item.h>

 #include "menu.h"
 #include "panel-action-button.h"

and with that patch I was able sucessfuly build mate-panel.

[kloczek]

BTW I made short test ..

[tkloczko@pers-jacek SPECS]$ rpmbuild -ba mate-panel.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
    121 -Wdeprecated-declarations
      6 -Wmisleading-indentation
      1 -Wunused-but-set-variable

It would be good start working on clean all those warnings ..

[raveit65]

#include <libmate-desktop/mate-image-menu-item.h>
https://github.com/mate-desktop/mate-panel/blob/master/mate-panel/panel-menu-items.c#L44

[lukefromdc]

So how is it anyone pulled from git and got source code with that line missing? Builds have worked on my end and without it would be expected to fail

[kloczek]

As you see I'm applying commits patches on top of dist tar ball.

[kloczek]

Just checked one more time dist tar ball and looks like it has missing that line..

[raveit65]

Because the commit which added that line was commited after the 1.27.2 release.
ebb3a79
I recommend using distro rpms from stable 1.26 branch eg. from fedora.