Comments (2)
It's in 1.4 :D
from react-cookie-consent.
Seems like a solid plan!
I can implement it for you later today or you can make a pull-request, either will be fine.
I feel that location and style are different things, so supplying "none" to the location would offer the most flexible solution in my opinion.
You'd have to change
export const OPTIONS = {
TOP: "top",
BOTTOM: "bottom"
};
into
export const OPTIONS = {
TOP: "top",
BOTTOM: "bottom",
NONE: ""
};
And we should update the proptype declaration too so that it will work with future values. Something like:
location: PropTypes.oneOf(Object.values(OPTIONS)),
Doing it like this would just ignore the switch and not add position styling whilst keeping it backwards compatible (e.g if we'd change disablestyles and people update it would affect their bar position).
Good idea man! Let's make this work!
from react-cookie-consent.
Related Issues (20)
- Unable to set domain via extraCookieOptions. Test suite failing with error message - Cookie has domain set to the public suffix "localhost" which is a special use domain HOT 2
- Cannot apply css for style -> bottom HOT 2
- Is there "agree" method without click agree using method HOT 1
- 'CookieConsent' cannot be used as a JSX component HOT 5
- decline Button Component HOT 3
- In Production Mode, myAwasumeCokkies2 is not storing in Cookies Storage Why? HOT 2
- HttpOnly option on Cookie settings HOT 2
- How to Close the CookieConsent window with onAccept HOT 1
- Consent Modal disappears when I scroll down HOT 4
- Consent Modal disappears when I scroll down HOT 2
- style margin bottom and bottom don't work HOT 2
- Update documentation to show support for custom cookie name HOT 2
- Q: Any docs on how to use with docusaurus? HOT 2
- How to detect cookies HOT 1
- component is suspended HOT 1
- `getCookieConsentValue` returns always undefined using custom cookie name HOT 4
- Type prop definition has too many required fields
- TypeError: Cannot read properties of undefined (reading 'prototype') HOT 7
- React Cookie Consent error when imported to a React component Next14
- I got error when I install package in nextjs 13 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-cookie-consent.