Comments (10)
I thought about this a while and i really don't see why you cannot keep the debian files there. Its just the one folder, so its pretty isolated. There are some projects which also keep their debian folder within the repository. Maybe, most people don't. But i assume that they have another build process and may have to keep build files for other distributions as well. Since i don't do that, i really have no benefit from that. In contrast to that i would have to change my whole build process.
from pulseaudio-dlna.
You don't have to change the whole build process to reach this. The simplest solution for this would be:
- add debian to the .gitignore file
- move the content of the debian directory to a new repository (git filter-branch can be used to keep the history of the directory)
- git clone of the new repository in the current working directory
With this there will be still some leftovers in the Makefile which could be moved in a next step to a different location.
from pulseaudio-dlna.
My python application reads the debian/changelog for the version and stuff.
So its not that simple. The salt and docker guys also maintain their debian packaging in their repos.
I really appreciate your efforts, but i don't see a real benefit of that.
from pulseaudio-dlna.
IMHO it's a bad design if the application code depends on some distribution specific code/stuff. But if this is the case then it's really not easy to solve this issue.
And btw. just because somebody else practices a bad design is no good reason for also practising a bad design 😉
So it's your decision whether you close this issue or leave it open to solve it eventually in the future.
from pulseaudio-dlna.
Hello,
talking about that, is anyone planning on distributing it in debian ?
I could review/upload it if needed. Seems nice. No device to test it with for now though.
About the debian-in-upstream problem: you can do that but it implies
author versions == debian versions, meaning it makes it harder for debian
maintainer(s) to patch and fix your software, especially if you stop developing
or releasing it.
It's usually simpler to just put the debian dir in another branch and rebase it on top of
master when you need to update it.
from pulseaudio-dlna.
Hi @masmu. First, thanks for this software, I have been using it with my chromecast audio recently and it works very well. I wanted to know if you have reconsidered what @kapouer and @coder-hugo have suggested regarding the debian/
directory you are providing. I am also interested in uploading this package to debian but this "issue" would hinder the maintenance. For instance, you wrote that your python application reads the version from debian/changelog
which translates in a difficulty for modifying the changelog for debian revisions. From another point of view, the philosophy behind the debian/
directory is that it has to be separated from the pristine source code and one has to make all changes to the source from there. I can understand that you don't see any benefit, and in general it is not bad per se (this is your effort to provide a debian package, and that's great) but it would ease the work for official Debian maintainers.
Distributing your package in debian, as I am sure you may know, would allow to increase the number of users and many people would beneficiate from this.
Below I just let a reference in case you are interested to check it out.
Regards,
https://wiki.debian.org/DebianMentorsFaq#What.27s_wrong_with_upstream_shipping_a_debian.2F_directory.3F
https://wiki.debian.org/UpstreamGuide#Initial_Packaging
from pulseaudio-dlna.
Well, I really like it to just make a new release entry in debian/changelog
and just hit make release
.
But okay, if I remove the version reading stuff, move the debian folder to a new branch, remove it from master, the release would not contain the folder anymore, which should fix the problem with the debian maintainers.
When doing my own ppa releases i just need to merge back master to my debian branch, make a new release entry there, and then hit make release
. Does this solve the issue or did i miss something?
from pulseaudio-dlna.
@masmu I think that that should solve the issue, and it won't disrupt too much your workflow to maintain your own ppa releases.
Thanks for considering this, and best regards.
from pulseaudio-dlna.
I moved the debian folder to a new branch, also called debian. So the new release 0.5.0 is the first one without it.
from pulseaudio-dlna.
@masmu thanks for this!.
from pulseaudio-dlna.
Related Issues (20)
- Chrome OS Support
- non-critical (?) error during setup of pulseaudio-dlna with Python 3.8
- The device "Living Room speaker (Chromecast)" failed to play! (500) - Unknown exception
- Outdated? 2020... HOT 3
- Any way to make this never the default ?
- ValueError: invalid literal for int() with base 10: '119,192.168.0.9' HOT 4
- Error after Kodi Update: pyupnpv2 - Connection timeout
- Don't work with pipewire-pulseaudio HOT 11
- "An exception happened" HOT 2
- Kubuntu 21.04 w/ backports HOT 1
- Is this project dead? HOT 1
- [not an issue] Addition to the Tested Device List: Allo Boss2 Player ruinning Moode UPNP (DLNA) - tested
- pulseaudio-dlna connects - but no sound! HOT 2
- Request 24 bit 96000 audio ouput
- Another request for FLAC 24/96 streaming
- Add support for OpenHome HOT 1
- Cannot add PPA: ''This PPA does not support focal''. HOT 1
- pulseaudio_dlna.streamserver provides wrong sample specs HOT 2
- Add more maintainers
- Propose another choice to stream audio to DLNA devices
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulseaudio-dlna.