Comments (6)
Looking at the code, I see that lines that have no indentation are ignored. It is not explicitly mentioned in the readme but I guess it makes sense, otherwise dedent
would do nothing in those cases and there would be no point in using it.
from dedent-js.
I've created a fix and PR. I'm using this internal to a yaml template tag function. Naturally YAML is very indent focused but the function doesn't know ahead of time if a dedent needs to occur before parsing the string to a JavaScript object.
from dedent-js.
Looking at the code, I see that lines that have no indentation are ignored. It is not explicitly mentioned in the readme but I guess it makes sense, otherwise
dedent
would do nothing in those cases and there would be no point in using it.
Should dedent
really be useful in this situation? I think consistent behaviour here has more advantages. Here are a few:
dedent
becomes an idempotent operation if this quirk is removed- When
dedent
is used for the purpose of making code more readable (I would speculate this is the most common use case), indentation is lost when a string happens to start from all the way at the left dedent-js
could provide a flag to explicitly remove indentation up to a specified depth, if that's what's desired, covering more use cases overall while making behaviour more consistent
from dedent-js.
Also Github reports that there are over 18 thousand repositories using this package. It is irresponsible to leave this awful quirk in the code.
from dedent-js.
A possible workaround is to add a space at the begging of each line
dedent(text.replace(/(^[^\n]|\n)/g, '$1 '))
from dedent-js.
I think the issue here is you might be using dedent-js
on something where you don't know the final tabbing. Because of that, it makes sense for dedent
to do nothing. I'm also for this change.
from dedent-js.
Related Issues (3)
- Issue with TS HOT 2
- Bug with escaped newlines HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dedent-js.