Inconsistent behavior between dump(obj, many=True) and Schema(many=True) about marshmallow

[sloria]

Can you please provide a full snippet to reproduce the problem? What data structure is mythings?

[svenstaro]

The problem is that in __filter_fields() you only check against self.many (but don't respect the many that was just was just passed into dump()). Same goes for _postprocess(). I don't think you need any additional code of mine here as the bug is right there but I can try providing a minimal test case that reproduces the problem if you really want. However, I think reasoning about the code, we can already see where it goes wrong.

I do agree that self.many should not be changed and my pull request is bad. The whole idea of having dump() take many as a parameter is that the object stays unchanged, after all. This being the case, many needs to be passed through all called functions instead, then.

[sloria]

@svenstaro You are correct. many will have to be passed through to those private functions. Would you like to update your pull request?