Coder Social home page Coder Social logo

Comments (7)

gregpriday avatar gregpriday commented on August 18, 2024

I fixed this issue by changing my own CSS, so it's not really a Blueberry issue. I was sizing my images using the CSS width:100%; height:auto.

It does seem like Blueberry crops your images by default, am I right? It would be nice to have an option to either crop or scale your slider images. I've added this to my fork.

from blueberry.

aranw avatar aranw commented on August 18, 2024

I have this issue as well and I can't fix it by altering my CSS like @gregpriday mentions.

Anyone know of another solution?

from blueberry.

aranw avatar aranw commented on August 18, 2024

I have traced this issue down to the following code...

$(window).resize(function(){
    setsize();
});

When ever the rotate is triggered with these three lines enabled you get a jump to the top.

from blueberry.

aranw avatar aranw commented on August 18, 2024

My issue was caused by having image height and width set on the elements. How this causes $(window).resize to jump to the top of the page I don't know...

from blueberry.

gregpriday avatar gregpriday commented on August 18, 2024

I'm not sure why a CSS changed fixed the issue for me, and not for you. The only thing I can suggest is that you wrap the image in a fixed size div before the image is resized and remove the wrapper afterwards. I'll take a look at the issue and see if I can fix it in my fork.

from blueberry.

gregpriday avatar gregpriday commented on August 18, 2024

I finally fixed this issue by modifying the rotate function. I changed it to start fading in the new image before it started fading out the old image. A very simple fix.

So this is what the first few lines of my rotate function look like now

slides.eq(next).fadeIn(o.duration).addClass('active').queue(function(){
        //add rotateTimer function to end of animation queue
        //this prevents animation buildup caused by requestAnimationFrame
        //rotateTimer starts a timer for the next rotate
        rotateTimer();
        $(this).dequeue()
    });
slides.eq(current).fadeOut(o.duration).removeClass('active');

from blueberry.

gjones avatar gjones commented on August 18, 2024

Hi Greg, following these instructions seems to break the slider if a user double clicks on the pagination instead of single clicks, may need to add a disable attr to the link thats currently active to fix this.

from blueberry.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.