Comments (5)
@fierysunset Is the problem that the attribute
input value in your example is not available when using c-input
? Since you can only have one input to the tag (c-input
takes precedence in this case) I am guessing that attribute
will not be passed along. Technically, I think the compiler should flag this as an error.
Here are some alternatives:
- Put the value of
attribute
intodata.someObj
and use<tagname c-input="data.someObj" />
. For example:
<assign var="data.someObj.attribute" value="test" />
<tagname c-input="data.someObj" />
- Don't use
c-input
but allow wildcard attributes fortagname
tag. See https://github.com/raptorjs/marko#defining-attributes - Declare a
data
(or some other name) attribute fortagname
that could be used as an alternate way to provide input. You could then use it like:
<tagname data="data.someObj" attribute="test"/>
Because data
is not a special attribute, the renderer for tagname
could access both data
and attribute
.
from marko.
I think the desired behavior is for the attributes to be merged into the data object provided by c-input
. The properties provided via attributes should take precedence over the properties in the the c-input
object. Also, we should not modify the object provided via c-input
and instead create a new object with the merged properties.
Is that what you are thinking as well, @fierysunset ? Thoughts @philidem ?
from marko.
Also, there are plenty of workarounds to avoid making this change, but I do think it is something we should just go ahead and fix since the current behavior of silently discarding the attributes when used in conjunction with c-input
is not right.
from marko.
New version published: [email protected]
from marko.
Yes to @patrick-steele-idem and thanks!
from marko.
Related Issues (20)
- Webpack error on Marko versions greater than 5.31.0 HOT 5
- Deprecation warnings in Chrome HOT 5
- `onInput` is not running when it is used in `component-browser.ts` HOT 1
- Static functions or arrow functions do not work on components without a class statement
- How does routing work? HOT 2
- Marko not properly tracking dependency updates in some situations when using the tags-api
- `Marko is not defined` when index.marko imports module from component.ts
- Cannot break generic parameter declarations into multiple lines HOT 3
- Specify Node Engine Constraint in package.json
- Removing a class attribute results in a "null" class HOT 5
- Out-of-order HTML streaming without JS using Declarative Shadow DOM HOT 15
- Uncaught DOMException on Marko 5.33.14 HOT 15
- Difference in dev/production builds
- `<await>` tag doesn't render correctly with `client-reorder` when inside `<table>` element HOT 3
- Unexpected rename destructed property data to input
- Marko + react
- Marko on Codepen HOT 1
- Marko load: Rank index.marko.js higher over index.js HOT 1
- Branch Coverage that can't be ignored HOT 1
- Broken prettier plugin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marko.