Comments (9)
See https://github.com/marklogic-community/RunDMC/blob/master/src/model/data-access.xqy#L405-L428. When searching on docs, $is-api
is true.
from rundmc.
Thanks for the pointer, @dmcassel . This line of that function looks particularly suspect:
https://github.com/marklogic-community/RunDMC/blob/master/src/model/data-access.xqy#L419
from rundmc.
agreed
from rundmc.
Confirmed that this is the way to fix the basic search problem.
The other half of this is to make the facets work. Currently, the hits in the jsdoc show up under a "Miscellaneous Pages" facet, which isn't very friendly of them. I think I know how and where to fix this, from chasing down how the Java Client facets work.
from rundmc.
I have a fix in hand. Waiting to hear back from Greg Nist if he wants his team to review it since it touches on the shared search code, rather than being specific to the doc portion of the app.
WRT facets, I got the facets working, but I punted on the facet icon. I just reused the folder icon that's the fallback icon. I refuse to get into hunting down some spiffy Node.js icon and adding it to the app.
from rundmc.
I have reviewed the code change and agree that it looks good. I also agree with your decision not to change the icon. Thanks!
from rundmc.
@gregnist I haven't checked my changes in yet or put together a pull request, so that's pretty impressive. ;)
I was waiting to hear back whether you wanted to review the changes or not. Since you do, I'll submit a pull request and notify you. Thanks!
from rundmc.
@gregnist The pull request is here, if you would like to take a look.
Not sure how I managed not to attach it to this issue. Idiot loose on the keyboard. Anyway, if you're OK with it, I'll merge it. It'll go on the docapp branch for now, but I'll be merging docapp out to master in a couple days, in preparation for 9.0-4.
from rundmc.
Deployed and tested on pubs. Fix will be pushed with 9.0-4.
from rundmc.
Related Issues (20)
- add special legal notices for Azure in doc site IP notice footer HOT 1
- Updates to the Industries list HOT 1
- Broken links in the blog feed HOT 1
- guide titles showing up wrong in search results HOT 2
- Semantics tutorial on DMC getting 404'd HOT 1
- X509 message code topics getting 404'd HOT 2
- Javadoc HTML fails to load with XDMP-TOOBIG HOT 2
- server download using curl flow is not working HOT 3
- MLW18 Ad
- Link to product notices does not resolve properly HOT 4
- Add IntelliJ plugin to Tools page
- Add ml-unit-test to Tools page
- change type mapping for item() in function signatures
- DMC sidebar now wraps at 1384 px and covers up doc nav controls HOT 1
- javadoc/jsdoc searchable docs are malformed HOT 1
- Cannot install RunDMC on ML 9 / CentOS: SECURITY-BADREQUEST
- "Type to filter TOC..." not working HOT 2
- 404 on http://docs.marklogic.com/10.0 HOT 2
- cntk namespace missing from namespace mappings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rundmc.