device-conf-gen: fopen() failure not handled correctly about mhvtl

[markh794]

Many thanks for the code review / sanity check. Appreciate the effort.
This seems like a very rare condition.
So my take on it is to "throw the baby out with the baby water" and abort(). Lets not die quietly.

[gonzoleeman]

Thanks for fixing!

…

-- Lee-Man Duncan Sent from my iPhone, dude

On Mar 8, 2022, at 11:51 AM, melak ***@***.***> wrote:  https://github.com/markh794/mhvtl/blob/88816cd3e89d9864947e8d93bb32e07813b7bda1/usr/mhvtl-device-conf-generator.c#L181 @gonzoleeman is this really supposed to fall through if the config file cannot be opened? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[melak]

Thanks for fixing indeed. I concur that this happening must have been an unconventional setup to begin with (I should know, I have one :), but if it happens, it's extremely hard to debug (don't ask how I know :).

Turns out this commit is only half the story though. I will be submitting a PR with some amendments to this shortly.