Enhancement idea: update vtlcmd to show the commit number and date released about mhvtl

[markh794]

Sounds like a good thing to add.. Let me work on it.

[markh794]

Is this the type of format you're interested in ?
$ vtlcmd -V
Version: 1.7.1, commit: 9548ed2, commit date: 2024-05-15T10:27:28+10:00

[rohr22]

I think I figured out how to download it so that vtlcmd -V shows the fuller version information. I just need to run "git clone https://github.com/markh794/mhvtl.git" and build from the source tree created from that.

[rohr22]

I think this might not be so easy to get the commit number since that is added by github, but maybe the date could be easier to show.

[markh794]

In the above example - is 'date created' - the git commit date, or the compile date of the binary itself ?

[rohr22]

It is the git commit date.

[rohr22]

Yeah, that should work.

[rohr22]

I guess you could shorten to something like this:

$ vtlcmd -V
Version: 1.7.1, commit: 9548ed2 (2024-05-15T10:27:28+10:00)

[rohr22]

Or maybe even:

$ vtlcmd -V
Version: 1.7.1, commit: 9548ed2 2024-05-15T10:27:28+10:00

[gonzoleeman]

On May 16, 2024, at 4:42 PM, Peter ***@***.***> wrote: Or maybe even: $ vtlcmd -V Version: 1.7.1, commit: 9548ed2 2024-05-15T10:27:28+10:00

Personally i think this is difficult to do, and not really needed. That’s what tags are for. To do this, as suggested, you’d need to commit it first, then build the binary. And it assumes git, correct? Why does the average user want to know the git commit id? Just my opinion. :) — Lee Duncan

[markh794]

I'm targeting the additional git version stuff for non RPM builds only. Let's see how it works out :)

[markh794]

Commit d6da2cb added this info. But only if built from git source. RPM based builds should (still) only report the RPM build version - e.g. 1.7.1

[rohr22]

Thank you very much for making these changes! I'll try it out soon and let you know what I think.

[rohr22]

Hi, Mark. I tried out the latest code and vtlcmd -V appears to have the same output as before. When I did the make, I saw stuff like this:

make[1]: Entering directory '/opt/vtl.source/commit_1582/mhvtl-master/usr'
cc -Wall -Wshadow -g -O2 -D_LARGEFILE64_SOURCE -I../kernel -I../ccan -DMHVTL_VERSION="1.7.1" -DMHVTL_GITDATE="" -DMHVTL_GITHASH=\"\" -D_GNU_SOURCE -DMHVTL_DEBUG -DMHVTL_HOME_PATH="/opt/vtl" -DMHVTL_CONFIG_PATH="/etc/mhvtl" -DSYSTEMD_SERVICE_DIR="/lib/systemd/system" -c -fpic log.c

The MHVTL_GITHASH value is "". I downloaded the latest mhvtl code (commit 1582) by clicking on the "Code" link at https://github.com/markh794/mhvtl and then clicking on "Download ZIP" from the HTTPS tab. What is the correct way to download the code so that MHVTL_GITHASH gets set properly? I looked at how it is set and config.mk has:

GITHASH ?= $(if $(shell test -d $(TOPDIR)/.git && echo 1),commit:\ $(shell git show -s --format=%h))

I don't have a .git directory under the top directory. Instead I have a .github directory.

Thank you,
Peter

[markh794]

Hi, Mark. I tried out the latest code and vtlcmd -V appears to have the same output as before. When I did the make, I saw stuff like this:

make[1]: Entering directory '/opt/vtl.source/commit_1582/mhvtl-master/usr' cc -Wall -Wshadow -g -O2 -D_LARGEFILE64_SOURCE -I../kernel -I../ccan -DMHVTL_VERSION="1.7.1" -DMHVTL_GITDATE="" -DMHVTL_GITHASH=\"\" -D_GNU_SOURCE -DMHVTL_DEBUG -DMHVTL_HOME_PATH="/opt/vtl" -DMHVTL_CONFIG_PATH="/etc/mhvtl" -DSYSTEMD_SERVICE_DIR="/lib/systemd/system" -c -fpic log.c

The MHVTL_GITHASH value is "". I downloaded the latest mhvtl code (commit 1582) by clicking on the "Code" link at https://github.com/markh794/mhvtl and then clicking on "Download ZIP" from the HTTPS tab. What is the correct way to download the code so that MHVTL_GITHASH gets set properly? I looked at how it is set and config.mk has:

GITHASH ?= $(if $(shell test -d $(TOPDIR)/.git && echo 1),commit:\ $(shell git show -s --format=%h))

I don't have a .git directory under the top directory. Instead I have a .github directory.

Thank you, Peter

Let me try that method and see if I can include check for .github dir :)