Coder Social home page Coder Social logo

Comments (6)

UziTech avatar UziTech commented on June 20, 2024

Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.

We decided to drop support a while ago for es5 since the es5 version of marked was about 30% slower than esNext.

It is unreasonable to believe marked knows what is best for all of its users. If you want speed you can use the esNext version. If you need wider support you can compile it with Babel.

from marked.

nbutmickey avatar nbutmickey commented on June 20, 2024

Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.

We decided to drop support a while ago for es5 since the es5 version of marked was about 30% slower than esNext.

It is unreasonable to believe marked knows what is best for all of its users. If you want speed you can use the esNext version. If you need wider support you can compile it with Babel.

  1. Do you have relevant data supporting the conclusion that the ES5 version of 'marked' is 30% slower than the ESNext version?

  2. I believe that as a library with such broad coverage, it should address compatibility issues. Assuming I create a library 'A' based on 'marked,' users of my library 'A' will install 'marked,' but if they don't use Babel to transpile ESNext code, issues may arise. We can't require all users to mandate Babel for compilation. This conclusion applies to library 'A' as well, and it's impractical to expect all authors of library 'A' to transpile your code.

In summary, I think it's crucial for an open-source library to handle compatibility issues well, or it can bring endless problems to developers.

from marked.

UziTech avatar UziTech commented on June 20, 2024

Do you have relevant data supporting the conclusion that the ES5 version of 'marked' is 30% slower than the ESNext version?

No, I encourage you to test it yourself. If you find a way to speed up marked, we are always accepting PRs ๐Ÿ˜๐Ÿ‘

In summary, I think it's crucial for an open-source library to handle compatibility issues well, or it can bring endless problems to developers.

I think you are confusing open-source software with software that developers get paid to maintain. Unfortunately all of the maintainers of marked help in our free time. As such we do not have time to handle compatibility issues well. Hence passing off the work of compiling to the users.

If you know of a better way to do it we are always accepting PRs ๐Ÿ˜๐Ÿ‘

from marked.

nbutmickey avatar nbutmickey commented on June 20, 2024

Understood. I might initiate a pull request.

from marked.

jjblumenfeld avatar jjblumenfeld commented on June 20, 2024

Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.

Can you describe a bit more how to implement this solution?

from marked.

UziTech avatar UziTech commented on June 20, 2024

@jjblumenfeld you can use babel to transpile the code you send to your users if you need to support older browsers. You may need to tell it to transpile node_modules modules depending on your settings.

from marked.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.