Comments (6)
Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.
We decided to drop support a while ago for es5 since the es5 version of marked was about 30% slower than esNext.
It is unreasonable to believe marked knows what is best for all of its users. If you want speed you can use the esNext version. If you need wider support you can compile it with Babel.
from marked.
Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.
We decided to drop support a while ago for es5 since the es5 version of marked was about 30% slower than esNext.
It is unreasonable to believe marked knows what is best for all of its users. If you want speed you can use the esNext version. If you need wider support you can compile it with Babel.
-
Do you have relevant data supporting the conclusion that the ES5 version of 'marked' is 30% slower than the ESNext version?
-
I believe that as a library with such broad coverage, it should address compatibility issues. Assuming I create a library 'A' based on 'marked,' users of my library 'A' will install 'marked,' but if they don't use Babel to transpile ESNext code, issues may arise. We can't require all users to mandate Babel for compilation. This conclusion applies to library 'A' as well, and it's impractical to expect all authors of library 'A' to transpile your code.
In summary, I think it's crucial for an open-source library to handle compatibility issues well, or it can bring endless problems to developers.
from marked.
Do you have relevant data supporting the conclusion that the ES5 version of 'marked' is 30% slower than the ESNext version?
No, I encourage you to test it yourself. If you find a way to speed up marked, we are always accepting PRs ๐๐
In summary, I think it's crucial for an open-source library to handle compatibility issues well, or it can bring endless problems to developers.
I think you are confusing open-source software with software that developers get paid to maintain. Unfortunately all of the maintainers of marked help in our free time. As such we do not have time to handle compatibility issues well. Hence passing off the work of compiling to the users.
If you know of a better way to do it we are always accepting PRs ๐๐
from marked.
Understood. I might initiate a pull request.
from marked.
Option 1 is already available for your project. You can use Babel to compile marked to whatever version of es you need.
Can you describe a bit more how to implement this solution?
from marked.
@jjblumenfeld you can use babel to transpile the code you send to your users if you need to support older browsers. You may need to tell it to transpile node_modules modules depending on your settings.
from marked.
Related Issues (20)
- Display Github permalink to a code snippet HOT 7
- Block level extension not rendering correctly HOT 2
- Emphasis cannot be rendered HOT 3
- could not resolve module HOT 4
- Support unordered lists with hyphens (-) in addition to asterisks (*) HOT 1
- problem when inserting a picture HOT 1
- Ignoring elements click prop on conversion HOT 1
- [Question] lexer - a `space` betwen two lists HOT 4
- Fail to parse image tag under specific input. HOT 2
- Feature request: footnotes HOT 1
- **xx** -> strong label, There is a problem HOT 1
- Support for chunked rendering HOT 1
- Unexpected behavior when using `marked.lexer` or `new marked.Lexer` HOT 1
- marked 13: TypeError: Cannot read properties of undefined (reading 'header') at _Renderer.tablecell HOT 2
- compiled code๏ผnamed # t and # e, which may cause errors in some versions of the browser. HOT 2
- Types for `this.parser` don't match notes of v13 release because `parser` is omitted HOT 3
- Incompatible/inconsistent types with `MarkedExtension` HOT 3
- Is it possible to create a custom extension using React Components (JSX)? HOT 1
- Possible bug with Renderer.link() HOT 2
- text in single ~ will be render del๏ผbut normally only text in ~~ should be render del HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marked.