[Bug Report] parse_ints function not working as expected in native libraray parse about c0vm-ts

[MarkChenYutian]

C0VM-ts/src/vm_core/native/native_parse.ts

Lines 91 to 95 in f4553c4

	const arrPtr: C0Pointer = mem.malloc(4 + 4 * ints.length);
	arrPtr.setInt32(0, 4); // sizeof(int) = 4
	for (let i = 0; i < ints.length; i ++) {
	arrPtr.setInt32(4 * (i + 1), ints[i]);
	}

Turns out in the native_parse.ts (the implementation of native parse library), when filling an allocated C0 int array with parsed JS value, I'm writing to the pointer instead of the heap memory (ArrayBuffer) the pointer is pointing to.

Going to fix this in next deployment.

[MarkChenYutian]

Correct implementation should be:

    // Create a c0 array and fill ints inside it
    const arrPtr: C0Pointer = mem.malloc(4 + 4 * ints.length);
    const arrMem: DataView  = mem.deref(arrPtr);
    arrMem.setInt32(0, 4);      // sizeof(int) = 4
    for (let i = 0; i < ints.length; i ++) {
        arrMem.setInt32(4 * (i + 1), ints[i]);
    }

instead.

[MarkChenYutian]

Similar bug in the same file:

C0VM-ts/src/vm_core/native/native_parse.ts

Lines 108 to 117 in f4553c4

	const arrPtr: C0Pointer = mem.malloc(4 + 8 * tokens.length);
	arrPtr.setInt32(0, 8);
	for (let i = 0; i < tokens.length; i ++) {
	const tokenPtr = allocate_js_string(mem, tokens[i]);
	// Sadly, Safari does not support BigInt (Uint64), so we have
	// to do this in two steps
	arrPtr.setUint32(4 + 8 * i, tokenPtr.getUint32(0));
	arrPtr.setUint32(4 + 8 * i + 4, tokenPtr.getUint32(4));
	}
	return arrPtr;

Fixed.