Coder Social home page Coder Social logo

Comments (11)

markblundeberg avatar markblundeberg commented on August 24, 2024 1

Good point about hiding / disabling. I should just make an error message when they try to open the tool, that explains what is going on. (multisig wallets are also affected)

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024 1

docs updated - 6882902

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024 1

hidden menu item thing fixed 3b0ca41

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024 1

Hey @johneas10, I'd recommend 'combine' and 'redeem with split' for simplicity. Make sure to do this when connected to a BCH server -- if you're connected to BSV server don't worry, it will just reject the transaction and you can try again.

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024

Yep, this won't work on hardware wallets. I had to make a choice of either:

  1. having the contract keys derived from wallet keys, which means your splitter coins' keys are fully recoverable with your wallet mnemonic.

  2. having random contract keys, which means lost funds in case your computer crashes and/or files become corrupted.

I went with the first option, which excludes watching-only and hardware wallets.

To split your hardware wallet coins, you should make a software wallet to do the splitting, and then send the result (a split coin) into your hardware wallet in order to mix with those unsplit hardware wallet coins.

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024

(That said, I should modify the code a bit so that the menu items don't appear / are disabled, for said wallets.)

from coinsplitter.

molecular avatar molecular commented on August 24, 2024

damn ;-(

thanks for not doing option 2, that would break reasonable assumption hd/hw wallet users make about the recoverability of their keys.

Is there any way to do this with trezor at all?

What do you suggest hw wallet users do to split coins? Funnel them through a non-hw wallet?

from coinsplitter.

markblundeberg avatar markblundeberg commented on August 24, 2024

Yes, indirectly:

  1. Create a software wallet in Electron Cash -- you can save the mnemonic somewhere low-security since you'll only be storing 1000 sats on this wallet.
  2. Open coin splitting tool.
  3. Fund! Copy the split contract address bitcoincash:p... and sent 1000 sats to it, using your hardware wallet software. (this Qt label should have selectable text so copy-paste should work.)
  4. When it comes time to split, open the software wallet and the splitter tool again -- it should find that 1000 sat utxo that you made.
  5. Get a receiving address from your hardware wallet like bitcoincash:qzzzzzzz. Enter that into the 'output address' field of the splitter tool.
  6. Spend! This sends a single tiny split coin into your hardware wallet.
  7. Sweep (Mix)! Use your hardware wallet software to sweep all coins (including the tiny split coin you just made). The result will be a single large split coin containing your entire wallet balance.

In this way, you never have to move anything but 1000 satoshis out of the hardware wallet.

from coinsplitter.

molecular avatar molecular commented on August 24, 2024

I see! Awesome, thank you so much for this tool and the info!

Maybe you could put that explanation for hw wallet users into your how to use .md?

Regarding removing menu items or greying them out for hw wallets: removing them would be a bad choice, I think, since users would then not know what's going on. Same with greying out: nothing more infuriating than a grayed-out menu item and no explanation. Can there be tooltips on grayed-out menu items? That way you could maybe link an explanation from there?

from coinsplitter.

eeston avatar eeston commented on August 24, 2024

Just to confirm, what options should we be selecting from here to spend:

Screenshot 2019-03-25 at 08 57 22

from coinsplitter.

eeston avatar eeston commented on August 24, 2024

Thanks @markblundeberg

Think that's me sorted now.

from coinsplitter.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.