Fix trap and loop device issue about fabscanpi-build-raspbian

[PhistterbutInc]

I've just come across the error involving loop device while building from script. Where would this code be placed to fix the issue?

I'm using VMware workstation to run ubuntu 18.04lts and build this script. Initially I had allocated too little storage and increased it later. I'm not sure if that's an issue or not.

Error: (the full log of output is much too long, this is the end)

Device Boot Start End Sectors Size Id Type
/pi-gen/work/2019-08-01-FabScanPi/export-image/2019-08-01-FabScanPi-lite.img1 8192 532480 524289 256M c W95 FAT32 (LBA)
/pi-gen/work/2019-08-01-FabScanPi/export-image/2019-08-01-FabScanPi-lite.img2 540672 4300799 3760128 1.8G 83 Linux

Command (m for help): The partition table has been altered.
Syncing disks.

losetup: /pi-gen/work/2019-08-01-FabScanPi/export-image/2019-08-01-FabScanPi-lite.img: failed to set up loop device: No such file or directory

real 76m12.174s
user 0m0.323s
sys 0m0.792s

[mariolukas]

This issue should be closed, cause this is not related to the new version of the build script since I switched to using the original pi-gen build script.
Anyway your issue seems to be similar. I would try to build a plain raspbian with pi-gen only. If this works the error is fabscan related. If it not works the loop device problem is a general problem of the build script and you should create an issue in the pi-gen project.
I don't know how Ubuntu handles loop devices in a VMWare session.

[mariolukas]

I changed the bash script. It will checkout the latest stable version ( currently buster build ) of pi-gen. This should prevent breaking changes in the master branch.
Maybe the README.md was also wrong. Try to use

sudo ./build-fabscan.sh

instead of

./build-fabscan.sh

Maybe this will fix the error because the default ubuntu user is not able to handle loop devices.

[PhistterbutInc]

I did use sudo ./build-fabscan.sh. I'll try building an image like you suggest and see what happens.

[mariolukas]

This issue is related to #15