Comments (4)
the output of the discussion today (internally in our team) is:
- we want to avoid defining new java API
- we want to use the feature of providing all possible outputs in the rule instance to a module, only if the module does not declare any inputs
- the map that is passed to ModuleHandler.execute will be used to pass the trigger outputs where the keys are triggerID.outputName
For example:
if we have a rule with 2 triggers ("trigger1" and "trigger2") of type GenericEventTrigger with 2 outputs "output1" and "output2"
the script expression for the condition is:
$trigger1.output2 == true || $trigger2.output1 == false
from smarthome.
Right, this resembles my idea.
Just one question: "only if the module does not declare any inputs" - why do you think this restriction is necessary? What's the benefit of it?
from smarthome.
done
from smarthome.
Closing it, but note that the chosen implementation still has a conceptional problem, see #118.
from smarthome.
Related Issues (20)
- Add unit tests for templates with composites
- Improve method names of ModuleTypeManager and TemplateManager
- Can we remove gson annotations from POJO objects? HOT 4
- Is the guava dependence is needed? HOT 2
- Add swagger annotations to rule rest resources HOT 6
- Swagger UI bundle for ESH that reads the swagger annotations from the REST resources HOT 6
- add a new feature for the automation bundles HOT 1
- NPE when stopping automation core
- merge automation.sample.handler bundles
- NPE when using gson parser HOT 2
- Add context for timer trigger (TimerTriggerTypeDefinition.json) HOT 1
- Context Keys for Scheduler (TimerTrigger) are not unique
- Add java api demo for new rule engine.
- Add rest api demo for new rule engine.
- Add JSON demo for new rule engine.
- Add performance testings for new rule engine
- Rule engine architecture doc must be created
- Rule engine tutorial has to be created
- Add missing information in response of "GET /rules/{ruleUID}" HOT 1
- rules cannot be created from paperUI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smarthome.