Loading fails with a module name ending `.js` about moduleserve

[JanKaul]

I think I have the same problem with popper.js. The program fails to load:

var _popper = _interopRequireDefault(require("popper.js"));

When I bundle it with webpack, it works fine.

[ochrons]

This popped up due to Reason React quick-start template starting to use moduleserve (instead of webpack dev server), and Ant Design depending on omit.js, so the combo didn't work. So there might more users to moduleserve in the future due to this Reason connection :)

[hunterwilliams]

We've got the same issue with our demo page for bs-mui (material ui); Pointing it to 7db414e makes it work.

[marijnh]

Could you see if attached patch helps for you?

[ochrons]

It doesn't seem to help. I think the problem is already in generating the request, as I'm seeing:

http://localhost:8000/moduleserve/mod/src/Index.bs/__mod/omit

which is already missing the .js suffix. Perhaps because of client.js

      var resp = get(base + name.replace(/(^|\/)\.\.(?=$|\/)/g, "$1__").replace(/\.js$/, ""))

[marijnh]

Ah, right, I only tested with curl, didn't actually go through the client.

That is a more complicated problem, since the client doesn't have the information needed to figure out whether a given module name can be safely normalized.

This system of normalization is intended to reduce the amount of requests the loader has to make—we need to address every module via a canonical URL to make caching (HTTP caching as well as local module instance caching) work. The assumption is that most modules will be require-d with a suffix-less name, so the server considers those names to be their canonical URL, to avoid an extra redirect for such names.

That turns out to be problematic. I expect it does avoid a lot of requests in typical code, but it is unclear how to work around this issue with it.

I'm probably not going to put more time into searching for a solution, since this is just a package that I use as a utility in some of my projects, and none of these projects have this issue. But if you have ideas for solution, let me know.

[ochrons]

If I look at the resolving algorithm at https://nodejs.org/api/modules.html#modules_all_together there is no dropping of .js suffix when loading modules. So is that even needed?

[marijnh]

As I mentioned above, it's a hack to reduce the number of requests.

[mcanobbio]

I have the same problem with popper.js that is being used by material-ui

[smh]

@marijnh: just a note, I had the same issue with dinero.js (through react-dinero). Switching to 7db414e solved it for me, albeit with an extra request (well worth it to me).