Rule to check that there is an extra line between node_modules and custom imports about tslint-origin-ordered-imports-rule

[marcuzy]

It's taken a bit more time to take it from here 😀. I've just released a new version which supports blank lines:

"rules": {
    "origin-ordered-imports": [ true, "one-blank-line" ]
}

It's also possible to require "no blank lines" or "at least one blank line", take a look at src/originOrderedImportsRule.ts to find out which options are supported.

I've also noticed it unluckily wasn't working with the latest TS, fixed that as well

[marcuzy]

@stas-kh you're right. Fixed it.

[marcuzy]

Hi! It's a good idea. I'll add it in the immediate future.

[stas-kh]

Thank you! Looking forward to such feature.

[stas-kh]

Big thank you @marcuzy
I will play with the rule tomorrow and let you know about the results!
Appreciate the work you've done!

[stas-kh]

Hey @marcuzy

I tested the new rule and found one issue, please correct me if I'm wrong.
We have the following rule in TSLint:

"max-line-length": [
  true,
  140
]

that restricts max length of a line to 140 symbols. Because of that rule some imports can be multilined with the following syntax:

import {
  Component,
  EventEmitter,
  Input,
  OnInit,
  Output,
  TemplateRef,
  ViewChild,
  ViewEncapsulation
} from '@angular/core';

import { UserInfo } from '../../local/interfaces/user-info.interface';
import { EmailInfo } from '../../../event/local/interfaces/email-info.interface';

In this case, the rule says there is an issue and doesn't let TSLint pass the linting

[stas-kh]

Thank you, @marcuzy
Now it works as expected!