`policy(route, request)` called 4 times during handling one request about spring-cloud-zuul-ratelimit

[marcosbarbero]

That's a good improvement.

[lchayoun]

For the shouldFilter and run I agree.
But the postFilter shouldFilter function should run it again in order to allow other filters to intervene.

[Aloren]

@lchayoun hm.. i didn't understand. why do we need to call policy(route(request), request) in post filter and can't use the value computed in prefilter?

[lchayoun]

The request can be changed by other filters during the request.
Computing and storing it will make the post filter ignore the change.

[Aloren]

good point. do you remember is there a test for such scenario?

[lchayoun]

I don't think so since the current tests are not adding custom filters to do so.

[marcosbarbero]

@Aloren are you willing to work on this one?

[Aloren]

@marcosbarbero sorry guys i'm currently short on time, hope to have some time on weekends. if you want to do it ASAP then of course you can start implementing it yourself.

[marcosbarbero]

Don’t worry, take your time! I just asked because in case you were not interested in implementing it yourself we should assign it internally.