ability to disable rate limiting basing on flag in request context about spring-cloud-zuul-ratelimit

[lchayoun]

It sounds to me that you need to create a filter that extends the RateLimitPreFilter and one that extends the RateLimitPostFilter
set zuul.rateLimit.enabled=false (or don't add it since it is the defualt) to disable the existing filters
then override the logic of the shouldFilter in each filter to match your dynamic logic

[lchayoun]

You can set the zuul.rateLimit.enabled=false, why do you need another flag?

[jakubzloczewski]

My need is to steer this flag in runtime - for example depending on request origin or user.

Do you suggest to wire RateLimitProperties bean and use setEnabled method to modify flag? I'm not sure if it is safe to modify it as it is global state not in context of request.

[jakubzloczewski]

Ok, thanks for advice. I will give a try.

[lchayoun]

@jakubzloczewski can we close this issue?

[fudali113]

@jakubzloczewski Do you think this will solve your problem? #41

[jakubzloczewski]

Yes, it works. Thanks!

[angshuman-agarwal]

It sounds to me that you need to create a filter that extends the RateLimitPreFilter and one that extends the RateLimitPostFilter
set zuul.rateLimit.enabled=false (or don't add it since it is the defualt) to disable the existing filters
then override the logic of the shouldFilter in each filter to match your dynamic logic

I tried this suggestion in version 2.2.1.RELEASE. But, I am getting error saying Could not autowire. No beans of 'RateLimitProperties' type found and same error for other classes being injected in ctor - RateLimiter, RateLimitKeyGenerator and RateLimitUtils.

Any idea how to make that work please ?

[marcosbarbero]

@angshuman-agarwal this issue was closed almost 3 years ago and a lot has changed to the project structure during this time. I recommend you open a new issue detailing your use-case.

[angshuman-agarwal]

Sorry about that. I have raised it separately - #396