Comments (5)
@kg-currenxie yeah that's somewhat related, this is like the combination of #63 and #64 🙃
from stimulus-parser.
Hey @MSchmidt, yeah, I think there are some cases were Stimulus LSP doesn't properly detect a controller imported via Importmaps, specficially if you import controllers from URLs? Is this also the case in your example?
Otherwise, would you mind showing your config/importmap.rb
? Thank you!
from stimulus-parser.
I'm storing everything locally. Installed with
bin/importmap pin stimulus-reveal-controller --download
The issue is specifically with stimulus-scroll-reveal
in this case.
# config/importmap.rb
pin "application", preload: true
pin "@hotwired/turbo-rails", to: "turbo.min.js", preload: true
pin "@hotwired/stimulus", to: "@hotwired--stimulus.js" # @3.2.2
pin "@hotwired/stimulus-loading", to: "stimulus-loading.js", preload: true
pin_all_from "app/javascript/controllers", under: "controllers"
pin "stimulus-dropdown" # @2.1.0
pin "hotkeys-js" # @3.12.0
pin "stimulus-use" # @0.51.3
pin "stimulus-scroll-reveal" # @3.2.0
from stimulus-parser.
Ah, I see. Thanks for the context @MSchmidt!
This is probably a duplicate of #64 in that case then.
from stimulus-parser.
I have a case like this
import Dropdown from 'stimulus-dropdown'
export default class extends Dropdown {
toggle(event) {
// custom code here
super.toggle()
}
hide(event) {
// custom code here
super.hide(event)
}
}
is this related? or should we track it in a new issue?
from stimulus-parser.
Related Issues (20)
- Support inferred Value Definition types
- Add `hasExplicitDefaultValue` to `ValueDefinition`
- Add `defaultValueLoc` getter to `ValueDefinition` HOT 1
- Using the defintionsFromContext webpack helper does not mark controllers as registered
- Invalid Stimulus Controller with multiple layouts/js files HOT 7
- stimulus-checkbox-select-all is somehow misbehaving and registering twice?
- All my Stimulus controllers are unregistered, even though they aren't
- Public class fields without a default value break the parser HOT 1
- Support dasherized controller filenames
- Error parsing private getters HOT 3
- Detect multiple Stimulus controllers in single file
- Support detecting controllers that don't end with the `_controller` suffix in the filename
- Support when controllers are imported with a different name compared to their actual filename
- External Stimulus components false positive HOT 1
- Function `analyzeStaticPropertiesExpressions` needs to take `object` into account
- Support Symfony's Stimulus Bridge
- Parse `ClassExpression` nodes as `ClassDeclarations`
- Parse kind of value definition
- Add nodes/locations to value definition parts HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stimulus-parser.