Goto Definition is broken about stimulus-lsp

[marcoroth]

Thanks for reporting this, @Gert-JanPeeters!

I wonder if VSCode would still accept it with the file:// scheme, so we could use the same code for both.

Looking at this line here, I'm wondering why I opted for stripping it 🤔

stimulus-lsp/server/src/service.ts

Line 29 in 88f5fe5

this.project = new Project(this.settings.projectPath.replace("file://", ""))

[Gert-JanPeeters]

I went searching a bit and found a similar issue:

NomicFoundation/hardhat-vscode#355

I think that VSCode can deal with both but Neovim is forcing LSPs to use an URI with a scheme. Not really sure which scheme it has to be used but I am guessing file://.

[marcoroth]

I guess in that case we should be able to use always use file:// then 👍🏼

[Gert-JanPeeters]

I have investigated a bit further.

I tried changing this line:

stimulus-lsp/server/src/service.ts

Line 29 in 86bd86b

this.project = new Project(this.settings.projectPath.replace("file://", ""))

to

this.project = new Project(this.settings.projectPath) 

But then things break. For example, stimulus-lsp cannot find the controllers anymore.

However, if I change:

stimulus-lsp/server/src/definitions.ts

Line 57 in 86bd86b

const locations = controllers.map((controller) => Location.create(controller.path, Range.create(0, 0, 0, 0)))

to:

const locations = controllers.map((controller) => Location.create(`file://${controller.path}`, Range.create(0, 0, 0, 0))) 

The Goto definition works in neovim. However, I don't think we should make the change here.

If I am correct then it is stimulus-parser that provides the paths to the locations? Maybe I should make an issue / pull request there to send the controller.path with the right scheme?

[marcoroth]

Thanks for investigating!

I think we should rather do it here in the repo, since this is more LSP specific. The Stimulus Parser could be used outside of an LSP context, which is why I think it doesn't really make sense to use the file:// scheme in the stimulus-parser project.