Line numbers in error messages are wrong about gravity

[marcobambini]

Hi @bardo84, can you please post an example?

[mwasplund]

Repro steps

Test.gravity

func main() {
	System.print("Run Tests!")
	error
}

Run

gravity Test.gravity

Expected

Error reported in file "Test.gravity" on line 3 character 2

Actual

SEMANTIC ERROR on 0 (5,2): Identifier error not found.

[mwasplund]

Should the '0' value be the file name?

[mwasplund]

FYI: Windows 11 running VS 2022 Version 17.4.3

[marcobambini]

Thanks @mwasplund, I see that you closed your pull request? That means that it was not ready to be applied?

[marcobambini]

Should the '0' value be the file name?

'0' is the fileID, the user is responsible to save the filename associated to each fileID.
See comment in

gravity/src/cli/gravity.c

Line 64 in 971337c

static const char *load_file (const char *file, size_t *size, uint32_t *fileid, void *xdata, bool *is_static) {

to get more information about to use the fileID.

[mwasplund]

Yes, it appears that in some cases when calling is_newline the current offset is pointing to the actual current token and in some cases it is already pointing to next. Still working out why this is the case.

[marcobambini]

I think that a good starting point to investigate is the is_newline function in gravity_lexer.c

gravity/src/compiler/gravity_lexer.c

Line 76 in 971337c

static inline bool is_newline (gravity_lexer_t *lexer, int c) {

[mwasplund]

That was were I was looking, I had updated the checks in that method to use PEEK_NEXT instead of PEEK_CURRENT. This resolved a lot of issues where the LF was getting missed and then double counted. However, it appears that in some cases the caller is "peeking" in which case the next char is actually current... I sent an update to pass in the exact next and next2 characters to the is_newline call. Not the prettiest, but it is working. Let me know if you see a cleaner way to achieve the difference in state between calls.