PhantomJS: yfavicon rule appear not to work with phantomjs about yslow

[soulgalore]

Ok, the thing is when populating the components in the phantomjs/controller, the favicon (and a couple of other types of requests, like Google fonts) hasn't been fetched by PhantomJS,meaning there is no request/response for it.

Did a fix for it in https://github.com/soulgalore/yslow doing a XMLHttpRequest per asset not existing, but think it could be done cleaner, so not sending a pull.

[marcelduran]

thanks, will take a look any time. currently swamped with twitter stuff,
sorry.

@marcelduran

On Thu, May 23, 2013 at 1:10 PM, Peter Hedenskog
[email protected]:

Ok, the thing is when populating the components in the
phantomjs/controller, the favicon (and a couple of other types of requests,
like Google fonts) hasn't been fetched by PhantomJS,meaning there is no
request/response for it.

Did a fix for it in https://github.com/soulgalore/yslow doing a
XMLHttpRequest per asset not existing, but think it could be done cleaner,
so not sending a pull.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-18368566
.

[soulgalore]

yes understand, I will clean up my fix and send a pull and then when you have time you can check how you can make it cleaner.