Colors will explode if multiple dependencies are using it about colors.js

[Marak]

Nope

[Almad]

@Marak Yep.

How to reproduce: please clone https://github.com/Almad/colors-dependency-bug-test & run node index.js

[Marak]

You are using unpublished version on MASTER.

Use the tagged release or the npm version.

[Almad]

@Marak to the best of my knowledge, "color" : "" in package.json uses latest published version from npm.

I have encountered this bug on stable, but I may define fixed version there too.

However, I think that synopsis is clear: colors is extending global objects and as color from second subdependency is not fetched from cache and color is extending String on import-time, it just tries to extend String again and fails.

[Almad]

...and apparently, I was mistaken.

Will report to the deps though, thanks.

[Marak]

It's because of this stupidity, I'll fix it when I feel like it. Published
version is not broken.

adf06f0

On Tue, Oct 23, 2012 at 1:05 PM, Almad [email protected] wrote:

@Marak https://github.com/Marak to the best of my knowledge, "color" :
"" in package.json uses latest published version from npm.

I have encountered this bug on stable, but I may define fixed version
there too.

However, I think that synopsis is clear: colors is extending global
objects and as color from second subdependency is not fetched from cache
and color is extending String on import-time, it just tries to extend
String again and fails.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-9716110.

[Almad]

yup, thanks.

After further investigation I found I am using devel version indeed, because published one was leaking.

Sorry for bothering.