Comments (2)
I would consider styling of subclass
optional.
One approach would be to introduce new poi_subclass
layers using the same approach as for class
-> "icon-image": "{subclass}_11"
in combination with filters to avoid styling the class
and subclass
of a POI (exclude it from class
styling when using the subclass
and include it for subclass
styling)
are there some features with an empty subclass?
good question 😉
if so, do we need a fallback?
no, because we would only style subclass
intentional (if there is one)
will we accept to duplicate lots of icons?
no
or can we create aliases in sprite.json?
aliases could work, never tried it. but I think there is no need, because we would only want to style a subclass if there is a dedicated icon for it available.
from osm-liberty.
Giving this some more thoughts, I think we should keep the existing layers and use a match expression like the following to style subclass:
"icon-image": ["match", ["get", "subclass"], ["florist", "furniture"], ["concat", ["get", "subclass"], "_11"], ["concat", ["get", "class"], "_11"]]
After #115 the expression could be reduced to:
"icon-image": ["match", ["get", "subclass"], ["florist", "furniture"], ["get", "subclass"], ["get", "class"]]
from osm-liberty.
Related Issues (20)
- One way arrow isn't very clear
- Styling for other point features besides POI
- Use only size 15 icons HOT 1
- More icons for POI subclass HOT 1
- Error reading style file HOT 5
- Change openmaptiles source from v3 to v3-openmaptiles
- Maptiler key broken HOT 2
- Vector natural earth tiles? HOT 5
- Wetlands styling HOT 8
- Add script to format and validate the style HOT 4
- Script to catch unnecessary style elements HOT 8
- One way roads HOT 1
- Highway shields HOT 3
- Host fonts in repository HOT 8
- Self hosted offline HOT 5
- Minor roads are over tertiaries HOT 2
- Pitch and tracks are not rendered
- Add rendering for place=quarter HOT 3
- Add building names HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm-liberty.