Style also POI subclass? about osm-liberty

[pathmapper]

I would consider styling of subclass optional.

One approach would be to introduce new poi_subclass layers using the same approach as for class -> "icon-image": "{subclass}_11" in combination with filters to avoid styling the class and subclass of a POI (exclude it from class styling when using the subclass and include it for subclass styling)

are there some features with an empty subclass?

good question 😉

if so, do we need a fallback?

no, because we would only style subclass intentional (if there is one)

will we accept to duplicate lots of icons?

no

or can we create aliases in sprite.json?

aliases could work, never tried it. but I think there is no need, because we would only want to style a subclass if there is a dedicated icon for it available.

[pathmapper]

Giving this some more thoughts, I think we should keep the existing layers and use a match expression like the following to style subclass:

"icon-image": ["match", ["get", "subclass"], ["florist", "furniture"], ["concat", ["get", "subclass"], "_11"], ["concat", ["get", "class"], "_11"]]

After #115 the expression could be reduced to:

"icon-image": ["match", ["get", "subclass"], ["florist", "furniture"], ["get", "subclass"], ["get", "class"]]