Coder Social home page Coder Social logo

Comments (3)

thunderhook avatar thunderhook commented on June 29, 2024

I thought this would be easy. However, they changed a lot of code. My approach with copying the old classes did not work. They also removed the com.intellij.codeInsight.daemon.impl.quickfix.SideEffectWarningDialog class, see: https://github.com/mapstruct/mapstruct-idea/actions/runs/6916833362/job/18817324564

It is still only in the LATEST-EAP-SNAPSHOT, will be likely in main with 2023.3 though.

I think we should either:

  • ignore the failure in the github actions for now
  • when 2023.3 is released: maybe disable the WrongUsageOfMappersFactoryInspection (not the most important intention)

I am not sure what happens when we switch to 2023.3 as the main version for development. I think this intention cannot run on older versions then? Or does it just not build with that version? We'll see.

from mapstruct-idea.

filiphr avatar filiphr commented on June 29, 2024

I had a look at it. They didn't remove it. They just changed it. They are now doing:

return new RemoveUnusedVariableFix(variable).asIntention();

I've done PR #162 for this

from mapstruct-idea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.