Coder Social home page Coder Social logo

Comments (9)

allthesignals avatar allthesignals commented on May 29, 2024 1

@marharyta I also am working on a few city projects, getting the same issue here.

I'll take a look and see if we can get it building!

from mapbox-gl-accessibility.

allthesignals avatar allthesignals commented on May 29, 2024 1

@tristen you bet! as soon as that's merged i'll PR a simple test suite so we can refactor stuff.

from mapbox-gl-accessibility.

tristen avatar tristen commented on May 29, 2024

Arrow functions were introduced in ES6!

from mapbox-gl-accessibility.

andrewharvey avatar andrewharvey commented on May 29, 2024

Thanks, With that in mind, I'll try a bit more to see if I can get it transpiling into a distributable build.

from mapbox-gl-accessibility.

marharyta avatar marharyta commented on May 29, 2024

@andrewharvey what is the situation with that? I am currently building an app that might critically need good a11y (city project) and I want to know if there is any CDN I can use? Thanks a lot for your work! Also, do you need help? I am not good with maps but I can try!

from mapbox-gl-accessibility.

andrewharvey avatar andrewharvey commented on May 29, 2024

@marharyta I'm not working on this at the moment, so feel free to give it a go yourself. You can take a look at a similar project https://github.com/mapbox/mapbox-gl-draw/blob/master/package.json and see how it generates the dist build and try to replicate that here?

from mapbox-gl-accessibility.

allthesignals avatar allthesignals commented on May 29, 2024

I am also running into this syntax error. Babel doesn't seem to be seeing this plugin: https://babeljs.io/docs/en/next/babel-plugin-proposal-class-properties.html

When I change the syntax from the arrow function style syntax to class method syntax (myProp = () => { } to myProp(){ }), I'm able to build; Babel can transform without issue.

There is a slight difference, but not relevant here. That said, I will keep trying to see why arrow function methods aren't working (I'd rather understand why this wasn't working in the first place than work around). Oops, it is relevant. These are event callbacks :) so binding matters.

Fork here until I get something ready for PR: https://github.com/allthesignals/mapbox-gl-accessibility

from mapbox-gl-accessibility.

allthesignals avatar allthesignals commented on May 29, 2024

What are some next steps for this? I want to help but I'm not sure what needs to happen to publish this onto npm and a CDN? I'm assuming this will need to happen on Mapbox's account...

from mapbox-gl-accessibility.

tristen avatar tristen commented on May 29, 2024

👋 @allthesignals I can help with the publish step to npm. OK to do that when #34 is merged?

from mapbox-gl-accessibility.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.