Coder Social home page Coder Social logo

Comments (4)

jdeniau avatar jdeniau commented on August 14, 2024

Hi, my math is far in my memory, but if rad and deg are angle units, so how do you convert a distance to an angle ? 🤔

from haversine.

jdeniau avatar jdeniau commented on August 14, 2024

To rephrase what I said : the input might be in rad or deg, but the output is actually a distance,

If I look at the scikit learn implementation of haversine that you referenced in #30 their output is also in kilometers:

scikitlearn:

>>> from sklearn.metrics.pairwise import haversine_distances
>>> from math import radians
>>> bsas = [-34.83333, -58.5166646]
>>> paris = [49.0083899664, 2.53844117956]
>>> bsas_in_radians = [radians(_) for _ in bsas]
>>> paris_in_radians = [radians(_) for _ in paris]
>>> result = haversine_distances([bsas_in_radians, paris_in_radians])
>>> result * 6371000/1000  # multiply by Earth radius to get kilometers
array([[    0.        , 11099.54035582],
       [11099.54035582,     0.        ]])

haversine:

>>> bsas = (-34.83333, -58.5166646)
>>> paris = (49.0083899664, 2.53844117956)
>>> haversine(bsas, paris)
11099.555687157774

from haversine.

MuellerSeb avatar MuellerSeb commented on August 14, 2024

An angle in radians is simply the distance on the unit-sphere. So to get the result in rad, you simply don't multiply with the earth radius. The dependence between angle and distance in linear (that is why the circumference of a circle is r * 2pi (where 2pi is a 360 deg angle))

Edit:
and as you see in the sklearn example the result of the haversine function is multiplied with the earth radius. The result itself is in radians.

from haversine.

jdeniau avatar jdeniau commented on August 14, 2024

Fixed by #40

from haversine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.