Coder Social home page Coder Social logo

Comments (3)

ivanschuetz avatar ivanschuetz commented on June 3, 2024

Hi! I'm considering working on this. There are several possibilities and wanted to clarify first:
(not super experienced with Rust, apologize for possible oversights)

  • TryFrom trait (since it can fail): this seems to require a bit awkward syntax when passing String, e.g:
Address::from_str(&*gen_response.address)
// or
(&*gen_response.address).try_into()
  • FromStr trait:
Address::from_str(&gen_response.address)
// or
gen_response.address.parse::<Address>()?

To convert to string, we'd to implement the ToString trait.

from algonaut.

manuelmauro avatar manuelmauro commented on June 3, 2024

Hi @i-schuetz ! I was thinking of this issue just yesterday, thanks for the analysis! In fact my doubt was the requirement for perfect conversion of the From trait and your solutions perfectly address the issue. I would go with the first option because I think that we will be using it especially with string slices and because the try_into feels cleaner than parse::<Address>. In theory we could implement both, but I think that is better to keep a single way of doing things whenever possible. What do you think?

from algonaut.

ivanschuetz avatar ivanschuetz commented on June 3, 2024

With parse actually we don't have to set the type, unless type inference doesn't work (which happens only in 2 places at the moment). Given this, I'm slightly in favor of it, as "parse" sounds a bit more accurate (and we don't need the &* syntax, which we'd need with TryInto, also in 2 places). I'll open the PR with this. Can change it.

from algonaut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.