Ignore Defective Entries [Suggection] about greg

[manolomartinez]

Hi, is there a traceback, apart from the error message, or just that?

When I have "downloadhandler = greg" set I just get the "...some went wrong" error, but when I have the downloadedhandler set to wget per the config file example I do get a traceback error. For example, the https://thisishell.com/broadcast.xml feed outputs:

Downloading Episode 895: Conservatism, A History (Best of... April 9th, 2016) -- 20160409.mp3
--2016-04-12 11:29:00-- https://s3.amazonaws.com/thisishell-assets/mp3/20160409.mp3
Resolving s3.amazonaws.com (s3.amazonaws.com)... 54.231.9.48
Connecting to s3.amazonaws.com (s3.amazonaws.com)|54.231.9.48|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: unspecified
ERROR: Redirection (301) without location.
Traceback (most recent call last):
File "/usr/bin/greg", line 9, in
load_entry_point('Greg==0.4.6', 'console_scripts', 'greg')()
File "/usr/lib/python3.5/site-packages/greg/gregparser.py", line 118, in main
function(vars(args))
File "/usr/lib/python3.5/site-packages/greg/greg.py", line 776, in sync
downloaded = feed.download_entry(entry)
File "/usr/lib/python3.5/site-packages/greg/greg.py", line 338, in download_entry
download_handler(self, placeholders)
File "/usr/lib/python3.5/site-packages/greg/greg.py", line 575, in download_handler
raise URLError
TypeError: init() missing 1 required positional argument: 'reason'

[FilipBB]

I made a small change to make greg continue syncing when a feed fails: FilipBB@e21fa87

There's probably a better way to do this, but I also use greg in a cron job and this works well enough for me.

[manolomartinez]

I am sorry I am not being very responsive these days. The end of semester is being more hectic than usual. Hopefully, after next Thursday I will be able to look into this and push a fix, perhaps based on @FilipBB's solution.

[manolomartinez]

@FilipBB I actually think now your solution is better than what greg currently has. Would you mind issuing a pull request with that commit?

[FilipBB]

Sure.

[manolomartinez]

So, we are going with @FilipBB's solution for the time being. I agree that keep-going seems like a better attitude in this context. Perhaps this should be another greg.conf flag?

Anyway, closing for now, unless and until you guys tell me that this is somehow misbehaving.