Coder Social home page Coder Social logo

Comments (5)

Mange avatar Mange commented on August 30, 2024

Sorry, that's not possible at the moment.

May I ask why it isn't easier to just write the correct URLs directly to the template? It would waste less clock cycles as well. :-)

I'm a bit undecided about the future of URL rewriting. It's error prone and should not be necessary much longer since Rails can handle that pretty well by itself.

I will consider it if you can make a good case for the feature, of course.

from roadie.

kandadaboggu avatar kandadaboggu commented on August 30, 2024

I am listing a product catalog entry in the email. I use absolute URL for <a> tags that I control. A section of the email shows the product description and this section has links to other resources in the site. The product description is generated by an off-line tool and it is meant to be shared across various product lines. Hence we keep the links in this text relative. So far it worked well as we were displaying the text within the context of a domain.

Recently, we started sending emails with the product information. The links in the description fail because they are relative. I was about to write a custom url handler for this section, and I decided to use nokogiri for parsing the fragment. I noticed that the roadie gem also uses nokogiri. I would save lot of cycles if I can have access to the nokogiri document before email text is generated.

It will be a good generic feature to allow users to add custom processing hooks to the HTML document.

from roadie.

Mange avatar Mange commented on August 30, 2024

That's a good reason for the new feature.

Feel free to open a pull request if you want it soon, because I have some larger changes in the pipe which I intend on finishing before jumping on this.

from roadie.

kandadaboggu avatar kandadaboggu commented on August 30, 2024

Please review my pull request #54.

I have named the converter configuration property as custom_converter. May be there is a better name for it.

from roadie.

Mange avatar Mange commented on August 30, 2024

This is now released in v2.4.0.

from roadie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.