Comments (5)
Sorry, that's not possible at the moment.
May I ask why it isn't easier to just write the correct URLs directly to the template? It would waste less clock cycles as well. :-)
I'm a bit undecided about the future of URL rewriting. It's error prone and should not be necessary much longer since Rails can handle that pretty well by itself.
I will consider it if you can make a good case for the feature, of course.
from roadie.
I am listing a product catalog entry in the email. I use absolute URL for <a>
tags that I control. A section of the email shows the product description and this section has links to other resources in the site. The product description is generated by an off-line tool and it is meant to be shared across various product lines. Hence we keep the links in this text relative. So far it worked well as we were displaying the text within the context of a domain.
Recently, we started sending emails with the product information. The links in the description fail because they are relative. I was about to write a custom url handler for this section, and I decided to use nokogiri
for parsing the fragment. I noticed that the roadie
gem also uses nokogiri
. I would save lot of cycles if I can have access to the nokogiri
document before email text is generated.
It will be a good generic feature to allow users to add custom processing hooks to the HTML document.
from roadie.
That's a good reason for the new feature.
Feel free to open a pull request if you want it soon, because I have some larger changes in the pipe which I intend on finishing before jumping on this.
from roadie.
Please review my pull request #54.
I have named the converter configuration property as custom_converter
. May be there is a better name for it.
from roadie.
This is now released in v2.4.0.
from roadie.
Related Issues (20)
- undefined method `children' for nil:NilClass HOT 13
- Support css_parser 1.4.x HOT 2
- Support Outlook's approach to margins HOT 2
- Media queries inlined HOT 9
- Roadie is erratically causing emails to be encoded differently HOT 3
- New release supporting Nokogiri 1.7? HOT 2
- Weird issue with content: '•'; in my CSS HOT 4
- Convert rem to px? HOT 1
- Allow anchor tags to be ignored HOT 3
- nokogiri is locked to 1.7.x, 1.8.x is out. HOT 5
- css_parser is locked to 1.4.x, 1.5.x is out HOT 6
- Add support for storing the document as XHTML HOT 3
- Stylesheet BOM stripping doesn't work with NetHttpProvider HOT 8
- support anchor/ image url stripping inside conditional tags HOT 5
- Image style attributes - Outlook (on windows) special cases HOT 1
- Transformation Hooks - readme out of date HOT 2
- [Announcement] Passive maintenance mode HOT 6
- Roadie output mangled when control chars are present in conditional comments HOT 1
- NoMethodError Exception: undefined method `match' for #<Hash:0x00000000062ecdf8> HOT 3
- Support CSS custom properties (variables) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roadie.