Comments (6)
You could create a file format collection as a chapter sheep-scan for unit testing
https://github.com/manga-download/sample-websites/tree/main/sheep-scanlations
from haruneko.
I see, so file extensions are not yet implemented...
Added a provisional patch in 41e76a1
from haruneko.
Are you sure they were stored as jpeg
and not as octet-stream
?
May need to improve the jpeg
detection to not falsely detect avif
as jpeg
from haruneko.
Idk what you mean by stored. Frontend preview show the type as octet-stream, but they are displayed accurately.
I said that when user ask to download then file are saved with .jpg extension, no matter what their content or mime type is.
May need to improve the jpeg detection to not falsely detect avif as jpeg
Afaik for now we force jpg extension on file names.
private async StoreImageFolder ....
const sc = this.Parent?.Parent['storageController'] as StorageController;
const data = await sc.LoadTemporary<Blob>(resources.get(index));
// TODO: determine file extension based on mime type
const extension = '.jpg';
const name = (index + 1).toString().padStart(digits, '0') + extension;
const file = await directory.getFileHandle(name, { create: true });
const stream = await file.createWritable();
await stream.write(data);
await stream.close();
My PR only make sure we got the good mime type. The actual "put the good extension on the file" is still to be done.
Moreover, there is this Common.ImageDirect (detect) flag to consider.
from haruneko.
Added a test manga with avif file : Rabbit's Bizarre Adventures
from haruneko.
I guess it can be closed for now
from haruneko.
Related Issues (20)
- Add file OremangaNet.mjs but not woking HOT 1
- Stuck in chapter fetching until timeout (recaptcha)
- (Feature Request) Context menu options in items pane HOT 2
- No Indicator chapters status in items pane HOT 1
- Mouse pointer is flickering HOT 1
- Better PDF/CBR/CBZ/EPUB generation ? HOT 5
- Image spacing in Viewer HOT 2
- Chapter file format HOT 2
- [NWjs] Window drag no longer working HOT 4
- Problem connecting to sites HOT 6
- Novels: how to handle them ?
- add download chapter as pdf HOT 1
- application is not opening on linux mint HOT 8
- Migration of mangas HOT 2
- There is an error when opening the website HOT 1
- (Site request) comicfans HOT 1
- Manual updating of source URL HOT 7
- Error with QUIC protocol?
- Downloaded chapters still show download icon HOT 3
- NW & Electron Limitations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haruneko.