Coder Social home page Coder Social logo

fuzzy search option about haruneko HOT 11 CLOSED

manga-download avatar manga-download commented on July 23, 2024
fuzzy search option

from haruneko.

Comments (11)

Sheepux avatar Sheepux commented on July 23, 2024 1

I'm mostly thinking on asian characters as they are quite a big part of the connectors.

from haruneko.

sisco0 avatar sisco0 commented on July 23, 2024

Should https://github.com/krisk/Fuse be an affordable option for us?

from haruneko.

sisco0 avatar sisco0 commented on July 23, 2024

@Robonau take a look at the PR video to get an idea of the implementation.

from haruneko.

Sheepux avatar Sheepux commented on July 23, 2024

I truly wonder how it behaves on non ASCII languages

from haruneko.

manh21 avatar manh21 commented on July 23, 2024

I truly wonder how it behaves on non ASCII languages

Fuse doesn't support searching through non-ASCII characters. Explained in this issues.
The known workaround is to convert non ASCII to ASCII using diacritics

from haruneko.

sisco0 avatar sisco0 commented on July 23, 2024

Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .

from haruneko.

manh21 avatar manh21 commented on July 23, 2024

@sisco0 you can find example data with asian characters in this manga list. More examples available at https://github.com/manga-download/hakuneko-cdn

from haruneko.

Sheepux avatar Sheepux commented on July 23, 2024

Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .

Actually i can't. That's something to be "defined". Or probably there should be some kind of (automatic?) function to disable the fuzzy search (can be done in another PR).
You can find special chars in the sheep's manga unit-test connector

@sisco0 you can find example data with asian characters in this [manga list]

Well need someone asian to let us know about issues around false positiv, to tell us about the quality of this feature on their languages.

from haruneko.

sisco0 avatar sisco0 commented on July 23, 2024

After testing the Sheep's Awesome Mangas connector, I have two conclusions made up:

  1. It seems that the search is working correctly when the exactly same symbols are taken as input, even with missing symbols in-between. Evidence is attached at the end of this message.
  2. The Real 23 example images are very funny, this was a really great surprise to find.

For sure, having a user who could test in-depth the filter feature for non-ASCII characters would be great.

image

from haruneko.

Sheepux avatar Sheepux commented on July 23, 2024

So the feature seems quite good.
So what is left ? Chapter search ? Connector search ?
Do we need regexp search as we have multiple chapter selection available.

from haruneko.

Sheepux avatar Sheepux commented on July 23, 2024

I'll close it for now. Fuzzy seems ok

from haruneko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.