Comments (11)
I'm mostly thinking on asian characters as they are quite a big part of the connectors.
from haruneko.
Should https://github.com/krisk/Fuse be an affordable option for us?
from haruneko.
@Robonau take a look at the PR video to get an idea of the implementation.
from haruneko.
I truly wonder how it behaves on non ASCII languages
from haruneko.
I truly wonder how it behaves on non ASCII languages
Fuse doesn't support searching through non-ASCII characters. Explained in this issues.
The known workaround is to convert non ASCII to ASCII using diacritics
from haruneko.
Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .
from haruneko.
@sisco0 you can find example data with asian characters in this manga list. More examples available at https://github.com/manga-download/hakuneko-cdn
from haruneko.
Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .
Actually i can't. That's something to be "defined". Or probably there should be some kind of (automatic?) function to disable the fuzzy search (can be done in another PR).
You can find special chars in the sheep's manga unit-test connector
@sisco0 you can find example data with asian characters in this [manga list]
Well need someone asian to let us know about issues around false positiv, to tell us about the quality of this feature on their languages.
from haruneko.
After testing the Sheep's Awesome Mangas
connector, I have two conclusions made up:
- It seems that the search is working correctly when the exactly same symbols are taken as input, even with missing symbols in-between. Evidence is attached at the end of this message.
- The Real 23 example images are very funny, this was a really great surprise to find.
For sure, having a user who could test in-depth the filter feature for non-ASCII characters would be great.
from haruneko.
So the feature seems quite good.
So what is left ? Chapter search ? Connector search ?
Do we need regexp search as we have multiple chapter selection available.
from haruneko.
I'll close it for now. Fuzzy seems ok
from haruneko.
Related Issues (20)
- Add file OremangaNet.mjs but not woking HOT 1
- Stuck in chapter fetching until timeout (recaptcha)
- (Feature Request) Context menu options in items pane HOT 2
- No Indicator chapters status in items pane HOT 1
- Mouse pointer is flickering HOT 1
- Better PDF/CBR/CBZ/EPUB generation ? HOT 5
- Image spacing in Viewer HOT 2
- Chapter file format HOT 2
- [NWjs] Window drag no longer working HOT 4
- Problem connecting to sites HOT 6
- Novels: how to handle them ?
- add download chapter as pdf HOT 1
- application is not opening on linux mint HOT 8
- Migration of mangas HOT 2
- There is an error when opening the website HOT 1
- (Site request) comicfans HOT 1
- Manual updating of source URL HOT 7
- Error with QUIC protocol?
- Downloaded chapters still show download icon HOT 3
- NW & Electron Limitations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haruneko.