MacOS maximized on start detection about haruneko

[sisco0]

Are we using the methods shown in https://svelte.dev/tutorial/custom-stores such as set?

[Sheepux]

No, we're using nwjs maximize function that should handle such case by itself.
So this is a nwjs issue, but it probably means that something is missing for MacOS (an app id?)

[sisco0]

I attach some lines of interest

haruneko/src/frontend/classic/Stores.ts

Line 4 in b55df89

export const WindowController = writable<IWindowController>();

haruneko/src/frontend/classic/Frontend.ts

Line 12 in a0641d4

WindowController.set(windowController);

haruneko/src/frontend/classic/components/AppBar.svelte

Line 40 in 5732218

maximize = $WindowController.Maximize.bind($WindowController);

haruneko/src/frontend/classic/components/AppBar.svelte

Lines 23 to 27 in 5732218

	winMaximized =
	window.outerWidth >= screen.availWidth &&
	window.outerHeight >= screen.availHeight &&
	window.screenTop <= screen['availTop'] &&
	window.screenLeft <= screen['availLeft'];

Maybe winMaximized is not set to true for the MacOS case as this last complex condition is not met as expected?

[Sheepux]

winMaximized is only here for the button action change
See

haruneko/src/frontend/classic/components/AppBar.svelte

Line 64 in 5732218

on:click={() => (winMaximized ? restore() : maximize())}

[Sheepux]

on windows winMaximized is struggling when moving the window from a 1080p to a 4K screen. Could be related

[Sheepux]

Possible issue with equality as the pixel ratio is not the same. There could be an error marging

haruneko/web/src/frontend/classic/components/AppBar.svelte

Line 36 in 4c19267

winMaximized =

(still investigating)

[Pierre-Monier]

For me (macOS M1 2020) I have no problem with maximized on start detection (on dev and prod), the issue I have is that winMaximized is not updated correctly. So I can only maximize or restore the app once, after that I'm blocked. The code is here :

    function updateWindowState() {
        winMaximized =
            window.outerWidth >= screen.availWidth &&
            window.outerHeight >= screen.availHeight &&
            window.screenTop <= screen['availTop'] &&
            window.screenLeft <= screen['availLeft'];
    }

The problem is that the window object is not updated inside the resize event listener, so winMaximized is never updated. I try getting the window object from the UIEvent but it's the same issue.

The only way to fix is to use nw.Window.get(). But since we wrap this inside the IWindowController, the clean way is to update this interface. So I prefer to ask first before I made any change.

Can you use the maximize button more than once on other platforms ?