Migrate bower + npm to only npm for dependency management about manageiq-ui-service

[chriskacerguis]

@himdel yeah, going to get @AllenBW and @chalettu to get it done this week (both the npm move and yarn)

[chriskacerguis]

cc @chalettu @dclarizio @martinpovolny @himdel @AparnaKarve

[AllenBW]

So it seems there are a few ways to skin this 😸 . One is to use yarn, (yarn install instead of npm install and bower install) but there are a few issues presently. Another is to completely rip out bower and use a combination of commonjs require and webpack/bowerserify to include the bundled assets in index.esj (leaning webpack)

If/when we move to angular 2, some key dependencies are published on npm but not bower (mainly https://ui-router.github.io/ng2/) .

I am mildly concerned that the trend of dependencies not being published on bower will cause trouble down the road. 🙈

[chriskacerguis]

I agree bower is dying. What is your recommendation for how to proceed?

[chalettu]

We can sit down and look at all our current dependencies, see if they are in npm. We can then look into integrating webpack and the combo above.

[AllenBW]

They are, already checked 🤘🎷🐯

On Oct 15, 2016 12:42 PM, "Chris Hale" [email protected] wrote:

We can sit down and look at all our current dependencies, see if they are
in npm. We can then look into integrating webpack and the combo above.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVSbKwD8jq0moSVAJt6qDT3N4GyqMWGks5q0QJfgaJpZM4KXZJE
.

[martinpovolny]

I wonder if the priority is to get it done here or in the operations UI or both? @himdel?

I started putting together list of tasks related to splitting the various UIs here: https://www.pivotaltracker.com/n/projects/1619601 and the npm migration is among those.

[himdel]

Agreed, we should migrate both, rather soon ideally. (In fact, I've already started looking into migrating manageiq, and there, we're missing a few dependencies.. angular-patternfly-sass, jquery-1.8, jquery.observe_field, kubernetes-topology-graph, manageiq-ui-components, patternfly-timeline, spice-html5-bower, xml_display - but I can fix that a bunch of those on Monday,)

As for yarn, on one hand it's very new, on the other, it does look good, is faster both when installing from scratch and when doing nothing, and since it uses the same node_modules and package.json and so can effectively be replaced by npm any time, I'd say what the hell, too tempting not to try :). I wonder if we'll want to .gitignore yarn.lock though, to get the same semantics as before.. (and I'm not yet clear when yarn updates that file - if it's only on explicit add or upgrade, maybe keeping the lock wouldn't be so bad..).
EDIT: ..assuming we can cache it on travis, otherwise, npm install -g yarn; yarn is probably slower than npm install

(Using yarn with bower.json does not work for the ops ui at all (it sorts it (whcih would break gulp inject BTW), reads .bowerrc, ..and deletes everything under vendor/assets/bower_components :)).)
This also means that we can't switch npm -> yarn without also doing (or having done) bower -> npm.

Agreed with webpack, even angular2-cli is switching from system,js to webpack, so no question there.. (Investigating webpack-rails for the ops ui)

[AllenBW]

🤘💪👦🍍🐯

On Oct 16, 2016 10:45 AM, "Chris Kacerguis" [email protected]
wrote:

@himdel https://github.com/himdel yeah, going to get @AllenBW
https://github.com/AllenBW and @chalettu https://github.com/chalettu
to get it done this week (both the npm move and yarn)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVSbFVoCQ_tq86M7wAb96dXvZnnMSeuks5q0kaggaJpZM4KXZJE
.

[himdel]

...as for yarn vs travis .. found https://twitter.com/kentcdodds/status/786282951210262528 .. may help ..