Comments (10)
@himdel yeah, going to get @AllenBW and @chalettu to get it done this week (both the npm move and yarn)
from manageiq-ui-service.
cc @chalettu @dclarizio @martinpovolny @himdel @AparnaKarve
from manageiq-ui-service.
So it seems there are a few ways to skin this 😸 . One is to use yarn, (yarn install
instead of npm install and bower install) but there are a few issues presently. Another is to completely rip out bower and use a combination of commonjs require
and webpack/bowerserify to include the bundled assets in index.esj (leaning webpack)
If/when we move to angular 2, some key dependencies are published on npm but not bower (mainly https://ui-router.github.io/ng2/) .
I am mildly concerned that the trend of dependencies not being published on bower will cause trouble down the road. 🙈
from manageiq-ui-service.
I agree bower is dying. What is your recommendation for how to proceed?
from manageiq-ui-service.
We can sit down and look at all our current dependencies, see if they are in npm. We can then look into integrating webpack and the combo above.
from manageiq-ui-service.
They are, already checked 🤘🎷🐯
On Oct 15, 2016 12:42 PM, "Chris Hale" [email protected] wrote:
We can sit down and look at all our current dependencies, see if they are
in npm. We can then look into integrating webpack and the combo above.—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVSbKwD8jq0moSVAJt6qDT3N4GyqMWGks5q0QJfgaJpZM4KXZJE
.
from manageiq-ui-service.
I wonder if the priority is to get it done here or in the operations UI or both? @himdel?
I started putting together list of tasks related to splitting the various UIs here: https://www.pivotaltracker.com/n/projects/1619601 and the npm migration is among those.
from manageiq-ui-service.
Agreed, we should migrate both, rather soon ideally. (In fact, I've already started looking into migrating manageiq, and there, we're missing a few dependencies.. angular-patternfly-sass
, jquery-1.8
, jquery.observe_field
, kubernetes-topology-graph
, manageiq-ui-components
, patternfly-timeline
, spice-html5-bower
, xml_display
- but I can fix that a bunch of those on Monday,)
As for yarn
, on one hand it's very new, on the other, it does look good, is faster both when installing from scratch and when doing nothing, and since it uses the same node_modules
and package.json
and so can effectively be replaced by npm
any time, I'd say what the hell, too tempting not to try :). I wonder if we'll want to .gitignore
yarn.lock
though, to get the same semantics as before.. (and I'm not yet clear when yarn
updates that file - if it's only on explicit add
or upgrade
, maybe keeping the lock wouldn't be so bad..).
EDIT: ..assuming we can cache it on travis, otherwise, npm install -g yarn; yarn
is probably slower than npm install
(Using yarn
with bower.json
does not work for the ops ui at all (it sorts it (whcih would break gulp inject
BTW), reads .bowerrc
, ..and deletes everything under vendor/assets/bower_components
:)).)
This also means that we can't switch npm
-> yarn
without also doing (or having done) bower
-> npm
.
Agreed with webpack
, even angular2-cli
is switching from system,js
to webpack
, so no question there.. (Investigating webpack-rails
for the ops ui)
from manageiq-ui-service.
🤘💪👦🍍🐯
On Oct 16, 2016 10:45 AM, "Chris Kacerguis" [email protected]
wrote:
@himdel https://github.com/himdel yeah, going to get @AllenBW
https://github.com/AllenBW and @chalettu https://github.com/chalettu
to get it done this week (both the npm move and yarn)—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#251 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGVSbFVoCQ_tq86M7wAb96dXvZnnMSeuks5q0kaggaJpZM4KXZJE
.
from manageiq-ui-service.
...as for yarn vs travis .. found https://twitter.com/kentcdodds/status/786282951210262528 .. may help ..
from manageiq-ui-service.
Related Issues (20)
- CVE-2022-31129 (High) detected in moment-2.24.0.tgz - autoclosed HOT 1
- Upgrade or remove Angular code. HOT 3
- CVE-2022-25869 (Medium) detected in angular-1.8.3.tgz HOT 1
- WS-2022-0284 (High) detected in moment-timezone-0.4.1.tgz, moment-timezone-0.5.33.tgz HOT 3
- WS-2022-0280 (High) detected in moment-timezone-0.4.1.tgz HOT 1
- WS-2022-0322 (High) detected in d3-color-1.4.1.tgz HOT 4
- CVE-2022-3517 (High) detected in minimatch-3.0.4.tgz - autoclosed HOT 1
- prepare the development environment to make code changes HOT 5
- CVE-2022-24999 (High) detected in qs-6.5.2.tgz - autoclosed HOT 1
- Unable to open a Native Console for a RHV VM in the Service UI
- CVE-2022-25881 (Medium) detected in http-cache-semantics-4.1.0.tgz - autoclosed HOT 1
- CVE-2023-28155 (Medium) detected in request-2.88.2.tgz - autoclosed HOT 1
- CVE-2023-26117 (Medium) detected in angular-1.8.3.tgz HOT 1
- CVE-2023-26118 (Medium) detected in angular-1.8.3.tgz HOT 1
- CVE-2023-26116 (Medium) detected in angular-1.8.3.tgz HOT 1
- CVE-2022-25883 (High) detected in semver-7.3.8.tgz - autoclosed HOT 1
- CVE-2020-23064 (Medium) detected in jquery-3.4.1.tgz, jquery-3.2.1.tgz - autoclosed HOT 1
- Opening the service ui results in downloading app.js over and over HOT 2
- CVE-2024-21490 (High) detected in angular-1.8.3.tgz
- CVE-2023-42282 (Critical) detected in ip-2.0.0.tgz - autoclosed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manageiq-ui-service.