Coder Social home page Coder Social logo

Comments (13)

epwinchell avatar epwinchell commented on July 18, 2024 1

@himdel Thanks. I'll have a go at it when I have a chance.

from manageiq-ui-service.

Fryguy avatar Fryguy commented on July 18, 2024

cc @martinpovolny @dclarizio @epwinchell

from manageiq-ui-service.

epwinchell avatar epwinchell commented on July 18, 2024

cc @himdel

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

OK, so, the skinning still works :)

Except that the devel-mode server serves images from client/images and not from .tmp/images where the build process puts them :). Still an issue, but doing gulp build and loading localhost:3000/self_service via Rails does give you the right image..

EDIT: aand fixed in #116

(The issue that this is not documented still remains...)

from manageiq-ui-service.

chriskacerguis avatar chriskacerguis commented on July 18, 2024

@himdel Can you please create the docs for this?

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

BTW @chriskacerguis , when I do the docs, I was thinking, maybe it'd be useful for SUI to actually contain a sample theme directory, and maybe even a test that tries to use the theme and validates it applied (although not sure such a test can be done within the realm of our testing framework (all that linking the theme in..), so not promising anything :) ).

What do you think? Would a sample theme make sense in the repo?

from manageiq-ui-service.

chriskacerguis avatar chriskacerguis commented on July 18, 2024

@himdel I think that is an AWESOME idea. I agree with the testing part, however @chalettu is working on setting up some better testing (https://saucelabs.com) so maybe after you get a sample theme, you could work with him with the testing ideas.

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

Hehe, thanks 🙇 :) Allright, will do :)

from manageiq-ui-service.

serenamarie125 avatar serenamarie125 commented on July 18, 2024

what do you mean by theme @himdel ?

I'd imagine that any rebranding that occurs for the Operations UI should be applied to the SSUI as well. We should discuss this from a UX perspective and make sure that the experience is correct.

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

@serenamarie125 Aah, by theme I mean specifically skin - a set of images, additional css files, and js text overrides that can be pulled in to rebrand SSUI..

from manageiq-ui-service.

serenamarie125 avatar serenamarie125 commented on July 18, 2024

👍 @himdel . FYI just sent out another email asking PM about requirements per branding as well. Thanks for the clarification here!

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

Created a PR with a sample skin documenting how it works, I'll pick the README to ManageIQ/guides too, once merged.

from manageiq-ui-service.

himdel avatar himdel commented on July 18, 2024

guides pr ManageIQ/guides#160

from manageiq-ui-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.