Coder Social home page Coder Social logo

Comments (11)

andyvesel avatar andyvesel commented on August 15, 2024

@skateman @abellotti I was trying to update a template with PUT/PATCH requests, but it only updates attributes for local MIQ database and doesn't make any calls to Fog, so the image can't be updated on the Openstack side. Do we need it to be implemented this way?
I'm kind of stuck on this issue. So I'll appreciate any thorough and obvious details about this.

from manageiq-api.

skateman avatar skateman commented on August 15, 2024

IMO we should somehow merge the two functionalities (i.e. the one @andyvesel created and the universal one I was trying to do) and call the openstack-specific stuff when needed.

from manageiq-api.

himdel avatar himdel commented on August 15, 2024

What @skateman said :)

Just, 2 more points:

  • please make sure you come up with an interface which can be generalized to any provider, no openstack-specific code in the API
  • the UiWorker is not guaranteed to be able to communicate with any external provider, and the same goes for the API => the API call should create a task to talk to the provider

from manageiq-api.

andyvesel avatar andyvesel commented on August 15, 2024

@himdel which means that CRUD code, that implemented here should be moved to main repo, it would be correct way?

from manageiq-api.

himdel avatar himdel commented on August 15, 2024

I'm sorry, that is more of a providers question.
(I think as long as update_image exists in the core, and returns an exception unless overriden, that's fine, but...)

from manageiq-api.

miq-bot avatar miq-bot commented on August 15, 2024

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

from manageiq-api.

martinpovolny avatar martinpovolny commented on August 15, 2024

Ok, so this is relevant for:

ManageIQ/manageiq-ui-classic#3944

Where we need to be able to create openstack images. Do we need an API action that can upload the image? Or just pass in a URL of it?

from manageiq-api.

martinpovolny avatar martinpovolny commented on August 15, 2024

Anyway it seems that for this to move forward work in needed from the core and provider (openstack) side.

from manageiq-api.

himdel avatar himdel commented on August 15, 2024

Where we need to be able to create openstack images. Do we need an API action that can upload the image? Or just pass in a URL of it?

This was never specified, and uploading would involve uploading a multi-gig image to the api appliance, potentially moving it to a different worker appliance and only then uploading to the provider. So, a public URL might be enough. (Cc @Loicavenel, https://bugzilla.redhat.com/show_bug.cgi?id=1487114)

from manageiq-api.

mfeifer avatar mfeifer commented on August 15, 2024

cc @agrare

from manageiq-api.

himdel avatar himdel commented on August 15, 2024

The BZ was closed as WONTFIX,
closing this issue to match https://bugzilla.redhat.com/show_bug.cgi?id=1487114

from manageiq-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.