Coder Social home page Coder Social logo

auto-height=calc broken about cycle2 HOT 2 CLOSED

malsup avatar malsup commented on September 27, 2024
auto-height=calc broken

from cycle2.

Comments (2)

sebastianschmid avatar sebastianschmid commented on September 27, 2024

pew. seems to me that the whole prodecure is flawed. A "debugger;" call reveals, that $(this), the slide, has zero height all of the time.

for me, this works:

        if ( autoHeight === 'calc' ) {
            // calculate tallest slide index
            opts.slides.each(function(i) {
                // debugger;
                // this one didn't work
                // var ratio = $(this).height() / $(this).width();
                var ratio = $('img',this).attr('height') / $('img',this).attr('width');
                opts.API.log('image '+i+': ratio='+ratio+' | max='+max);
                if ( ratio > max ) {
                    max = ratio;
                    autoHeight = i;
                }
            });
        }

since I put the height and width of each image in the according attribute. It's neither fully tested, nor a complete solution.

Update:
See live at http://www.dietersteinbach.com/
Resize window to be about 400px wide (minimum possible width in chrome) to see the mobile stylesheet.

from cycle2.

malsup avatar malsup commented on September 27, 2024

Yeah, that's pretty tricky if you have variable sized images set to 'auto' height. Another approach would be to delay the style initialization until after cycle has a chance to calculate the correct sentinel:

.cycle-slide img { display: block }


$('.slideshow').on('post-intialize', function() {
    $('.cycle-slide img').css({ maxWidth: '100%', height: 'auto' });
});

from cycle2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.