Invalid syntax with python 2.6 about django-geojson

[leplatrem]

What is your version of python ?

Relative imports came in 2.4 AFAIK

[ozzmos]

I'm running python 2.6.6

[leplatrem]

Can you send me your code and the whole stacktrace please ? (on http://friendpaste.com for example...)
Thanks

[ozzmos]

I have made another test and it's working. with python 2.7.3

[leplatrem]

I got it : https://github.com/makinacorpus/django-geojson/blob/master/djgeojson/serializers.py#L91

[ozzmos]

Indeed, it seems the instanciation within the loop is the problem.
I change this by:

if self.selected_fields is not None:
for k,v in properties.items():
if k in self.selected_fields:
properties = {k:v}
# properties = {k:v for k,v in properties.items() if k in self.selected_fields}
# Properties are expected to be serializable, force it brutally
properties = simplejson.loads(simplejson.dumps(properties, cls=DateTimeAwareJSONEncoder))
return properties

and now it's working.

[leplatrem]

Yes, dict comprehension came in 2.7 : http://www.python.org/dev/peps/pep-0274/
You can open a pull-request :)

properties = {k:v for k,v in properties.items() if k in self.selected_fields}

can indeed be replaced with something like :

for k,v in properties.items():
    if k not in self.selected_fields:
        del properties[k]

[rodo]

This problem seems to be fixed, am I right ?

[ozzmos]

yes it is ;-)