Support for custom livenessProbe and readynessProbe values about helm-charts

[l-e-e-o]

I ran into the same problem as you. After unsuccessfully fiddling around with the values I decided to read the documentation again and discovered there seems to be a solution for this exact problem: startup probes. Maybe you want to add this to your PR as well.

[jochenkluger]

Thank you for your comment. Sure, it would be consequent to add the startup probes as well.
I will modify the PR in the next days.
In the end, my problem could be solved by modifying the ressource limits and I could return to the default probes.

[jochenkluger]

As the original mailu charts do not contain startup checks, I added them conditionally.
So the behaviour does not change as long as no startupProbe section is added e.g.:
admin:
image:
repository: mailu/admin
podAnnotations: {}
resources:
limits:
cpu: 600m
memory: 500Mi
requests:
cpu: 500m
memory: 500Mi
startupProbe:
periodSeconds: 999
failureThreshold: 999
timeoutSeconds: 999

[micw]

Hello,
I'm reading this with big interest, especially the "startupProbe" (which I did not knew before).

I find the if...default...else syntax you introduced to the existing probes a bit confusing. I suggest that we move the defaults entirely to values.yaml and make each probe conditional, as you did in startupProbes:

https://github.com/Mailu/helm-charts/pull/105/files#diff-aa6e5cf58dc2c22b574fd3cebef88d8c0858896419fccc3fb79d469f88bbf45cR147-R155

With startup probes, it makes also sense to re-think the (probably "randomly") selected defaults.

[jochenkluger]

Hi,
I took the defaults from the existing templates and the if...default...else syntax was used to make it possible to keep the template defaults and just change a specific value.
The actual default values in the startup probes are just copies of the other probes.

We can change all probes to the pattern used in the startup probes, then the complete probe section has to be configured in values.yaml.

[micw]

@jochenkluger @l-e-e-o I'd be happy if you could have a look at #115 which is a modified version of the original PR.

[micw]

I merged #115 (and bumped chart version to avoid compatibility issues). I moved the long startup delays to the defaults for startupProbe and added an additional one for rspamd (to solve the mentioned startup issue). If it still makes problems, feel free to open a new issue at any time.